threads / patch / 25014

patchbuiltin/clean.c: Use STRING_LIST_INIT_NODUP.

Subject: [PATCH] builtin/clean.c: Use STRING_LIST_INIT_NODUP.

## tl;dr

3 messages between Sep 6, 2010 and Sep 7, 2010. Diffs are folded; open one to read it.

replies: 2people: 2as markdown or json

Thiago Farina· Sep 6, 2010, 23:32 UTC · lore

Signed-off-by: Thiago Farina <tfransosi@gmail.com>
---
 builtin/clean.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

Show changes to builtin/clean.c +1 −1

diff --git a/builtin/clean.c b/builtin/clean.c
index b508d2c..c8798f5 100644
--- a/builtin/clean.c
+++ b/builtin/clean.c
@@ -44,7 +44,7 @@ int cmd_clean(int argc, const char **argv, const char *prefix)
 	struct dir_struct dir;
 	static const char **pathspec;
 	struct strbuf buf = STRBUF_INIT;
-	struct string_list exclude_list = { NULL, 0, 0, 0 };
+	struct string_list exclude_list = STRING_LIST_INIT_NODUP;
 	const char *qname;
 	char *seen = NULL;
 	struct option options[] = {

-- 
1.7.2.3.313.gcd15

Junio C Hamano· Sep 6, 2010, 23:56 UTC · re: Thiago Farina · lore

Re: [PATCH] builtin/clean.c: Use STRING_LIST_INIT_NODUP.

Good eyes. Is this the last spelled-out initialization (I didn't check deeper than running a quick grep for "struct string_list .*= *{")?

Thanks.

Thiago Farina· Sep 7, 2010, 00:03 UTC · re: Junio C Hamano · lore

Re: [PATCH] builtin/clean.c: Use STRING_LIST_INIT_NODUP.

On Mon, Sep 6, 2010 at 8:56 PM, Junio C Hamano <gitster@pobox.com> wrote:

> Good eyes.  Is this the last spelled-out initialization (I didn't check
> deeper than running a quick grep for "struct string_list .*= *{")?
>

Yup! This is the last. :)

I checked firstly with: $ git grep -e 'struct string_list [^ ]* = {.*'

And then with yours: $ git grep -e "struct string_list .*= *{"