{"thread":{"id":"25014","subject":"[PATCH] builtin/clean.c: Use STRING_LIST_INIT_NODUP.","startedAt":"2010-09-06T23:32:55Z","lastAt":"2010-09-07T00:03:19Z","messageCount":3,"participants":["Thiago Farina","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"150150","messageId":"1283815975-11107-1-git-send-email-tfransosi@gmail.com","threadId":"25014","inReplyTo":null,"subject":"[PATCH] builtin/clean.c: Use STRING_LIST_INIT_NODUP.","fromName":"Thiago Farina","fromEmail":"tfransosi@gmail.com","sentAt":"2010-09-06T23:32:55Z","receivedAt":"2010-09-06T23:32:55Z","isPatch":true,"sender":{"key":"tfransosi@gmail.com","avatar":"https://avatars.githubusercontent.com/u/970071?v=4"},"body":"Signed-off-by: Thiago Farina <tfransosi@gmail.com>\n---\n builtin/clean.c |    2 +-\n 1 files changed, 1 insertions(+), 1 deletions(-)\n\ndiff --git a/builtin/clean.c b/builtin/clean.c\nindex b508d2c..c8798f5 100644\n--- a/builtin/clean.c\n+++ b/builtin/clean.c\n@@ -44,7 +44,7 @@ int cmd_clean(int argc, const char **argv, const char *prefix)\n \tstruct dir_struct dir;\n \tstatic const char **pathspec;\n \tstruct strbuf buf = STRBUF_INIT;\n-\tstruct string_list exclude_list = { NULL, 0, 0, 0 };\n+\tstruct string_list exclude_list = STRING_LIST_INIT_NODUP;\n \tconst char *qname;\n \tchar *seen = NULL;\n \tstruct option options[] = {\n-- \n1.7.2.3.313.gcd15\n"},{"id":"150157","messageId":"7vpqwqs9xu.fsf@alter.siamese.dyndns.org","threadId":"25014","inReplyTo":"1283815975-11107-1-git-send-email-tfransosi@gmail.com","subject":"Re: [PATCH] builtin/clean.c: Use STRING_LIST_INIT_NODUP.","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2010-09-06T23:56:29Z","receivedAt":"2010-09-06T23:56:29Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Good eyes.  Is this the last spelled-out initialization (I didn't check\ndeeper than running a quick grep for \"struct string_list .*= *{\")?\n\nThanks.\n"},{"id":"150159","messageId":"AANLkTinGdaAgnYBGB2Y9O6=JrnjqAqRkcNewoT1=jwXL@mail.gmail.com","threadId":"25014","inReplyTo":"7vpqwqs9xu.fsf@alter.siamese.dyndns.org","subject":"Re: [PATCH] builtin/clean.c: Use STRING_LIST_INIT_NODUP.","fromName":"Thiago Farina","fromEmail":"tfransosi@gmail.com","sentAt":"2010-09-07T00:03:19Z","receivedAt":"2010-09-07T00:03:19Z","isPatch":true,"sender":{"key":"tfransosi@gmail.com","avatar":"https://avatars.githubusercontent.com/u/970071?v=4"},"body":"On Mon, Sep 6, 2010 at 8:56 PM, Junio C Hamano <gitster@pobox.com> wrote:\n> Good eyes.  Is this the last spelled-out initialization (I didn't check\n> deeper than running a quick grep for \"struct string_list .*= *{\")?\n>\nYup! This is the last. :)\n\nI checked firstly with:\n$ git grep -e 'struct string_list [^ ]* = {.*'\n\nAnd then with yours:\n$ git grep -e \"struct string_list .*= *{\"\n"}]}