threads / discuss / 2400

git-pull.sh's bad mode

Subject: git-pull.sh's bad mode

## tl;dr

5 messages between Nov 8, 2005 and Nov 8, 2005.

replies: 4people: 3as markdown or json

Jon Loeliger· Nov 8, 2005, 14:19 UTC · lore

Public apology and brown paper bag. My patch accidentally twiddled the mode on git-pull.sh:

    Signed-off-by: Jon Loeliger <jdl@freescale.com>
    ---
     Documentation/git-pull.txt        |   17 +++++++----------
     Documentation/merge-options.txt   |   16 ++++++++++++++++
     Documentation/merge-pull-opts.txt |   14 --------------
     git-format-patch.sh               |    4 ++++
     git-pull.sh                       |   12 +++++++++++-
     9 files changed, 70 insertions(+), 48 deletions(-)
     create mode 100644 Documentation/fetch-options.txt
     create mode 100644 Documentation/merge-options.txt
     delete mode 100644 Documentation/merge-pull-opts.txt
     mode change 100755 => 100644 git-pull.sh
Junio C Hamano· Nov 8, 2005, 16:25 UTC · re: Jon Loeliger · lore

Re: git-pull.sh's bad mode

Jon Loeliger <jdl@freescale.com> writes:
> Public apology and brown paper bag.  My patch
> accidentally twiddled the mode on git-pull.sh:
>
>      mode change 100755 => 100644 git-pull.sh

No need for worrying things like this. Mistakes and accidents happen.

Makefile installs git-pull with executable bit set anyway, so it really does not matter.

-jc
Petr Baudis· Nov 8, 2005, 16:35 UTC · re: Junio C Hamano · lore

Re: git-pull.sh's bad mode

Dear diary, on Tue, Nov 08, 2005 at 05:25:56PM CET, I got a letter where Junio C Hamano <junkio@cox.net> told me that...

Show 12 quoted lines
> Jon Loeliger <jdl@freescale.com> writes:
> 
> > Public apology and brown paper bag.  My patch
> > accidentally twiddled the mode on git-pull.sh:
> >
> >      mode change 100755 => 100644 git-pull.sh
> 
> No need for worrying things like this.  Mistakes and accidents
> happen.
> 
> Makefile installs git-pull with executable bit set anyway, so it
> really does not matter.

But it should definitely be fixed. E.g. I actually personally use (for Cogito development) git-core which I never make install (I have system-wide git-core installation which is just whatever is the latest version Gentoo ships, and I use that for non-Cogito development). It would be painful if this mode of usage wouldn't be supported.

-- 
				Petr "Pasky" Baudis
Stuff: http://pasky.or.cz/
VI has two modes: the one in which it beeps and the one in which
it doesn't.
Junio C Hamano· Nov 8, 2005, 19:30 UTC · re: Petr Baudis · lore

Re: git-pull.sh's bad mode

Petr Baudis <pasky@suse.cz> writes:
Show 8 quoted lines
>> Makefile installs git-pull with executable bit set anyway, so it
>> really does not matter.
>
> But it should definitely be fixed. E.g. I actually personally use (for
> Cogito development) git-core which I never make install (I have
> system-wide git-core installation which is just whatever is the latest
> version Gentoo ships, and I use that for non-Cogito development).
> It would be painful if this mode of usage wouldn't be supported.

You could perhaps do "make" without install and set PATH to include the source directory (you need to do a bit more if we ever update templates/ directory and you would want to try it).

The point is that git-pull was generated with +x from git-pull.sh, and the mode bits of git-pull.sh (source) does not matter anymore. It used to matter back when we called them git-*-script but not these days.

Petr Baudis· Nov 8, 2005, 19:39 UTC · re: Junio C Hamano · lore

Re: git-pull.sh's bad mode

Dear diary, on Tue, Nov 08, 2005 at 08:30:10PM CET, I got a letter where Junio C Hamano <junkio@cox.net> told me that...

> You could perhaps do "make" without install and set PATH to
> include the source directory (you need to do a bit more if we
> ever update templates/ directory and you would want to try it). 
That's what I do.
> The point is that git-pull was generated with +x from
> git-pull.sh, and the mode bits of git-pull.sh (source) does not
> matter anymore.  It used to matter back when we called them
> git-*-script but not these days.

Ah so. I see. Well, still useful when I'm changing something and I'm lazy to remake after each change. ;-)

Either way, it should be consistent for all the scripts - either +x or -x (but yes, definitely not a brown paper bag thing :).

-- 
				Petr "Pasky" Baudis
Stuff: http://pasky.or.cz/
VI has two modes: the one in which it beeps and the one in which
it doesn't.

← back to recent threads