{"thread":{"id":"2400","subject":"git-pull.sh's bad mode","startedAt":"2005-11-08T14:19:38Z","lastAt":"2005-11-08T19:39:03Z","messageCount":5,"participants":["Jon Loeliger","Junio C Hamano","Petr Baudis"],"isPatch":false,"patchVersion":null,"patchTotal":null},"messages":[{"id":"11322","messageId":"E1EZUK2-0005EG-56@jdl.com","threadId":"2400","inReplyTo":null,"subject":"git-pull.sh's bad mode","fromName":"Jon Loeliger","fromEmail":"jdl@freescale.com","sentAt":"2005-11-08T14:19:38Z","receivedAt":"2005-11-08T14:19:38Z","isPatch":false,"sender":{"key":"jdl@jdl.com","avatar":"https://gravatar.com/avatar/75ce9a10b151acd2c28ec4ab2136dba7b2ff1634530bd04b155981a749d08a64?d=mp&s=160"},"body":"\nPublic apology and brown paper bag. My patch\naccidentally twiddled the mode on git-pull.sh:\n\n Signed-off-by: Jon Loeliger \n\n ---\n\n Documentation/git-pull.txt | 17 +++++++----------\n Documentation/merge-options.txt | 16 ++++++++++++++++\n Documentation/merge-pull-opts.txt | 14 --------------\n git-format-patch.sh | 4 ++++\n git-pull.sh | 12 +++++++++++-\n 9 files changed, 70 insertions(+), 48 deletions(-)\n create mode 100644 Documentation/fetch-options.txt\n create mode 100644 Documentation/merge-options.txt\n delete mode 100644 Documentation/merge-pull-opts.txt\n mode change 100755 => 100644 git-pull.sh\n"},{"id":"11326","messageId":"7v4q6njecr.fsf@assigned-by-dhcp.cox.net","threadId":"2400","inReplyTo":"E1EZUK2-0005EG-56@jdl.com","subject":"Re: git-pull.sh's bad mode","fromName":"Junio C Hamano","fromEmail":"junkio@cox.net","sentAt":"2005-11-08T16:25:56Z","receivedAt":"2005-11-08T16:25:56Z","isPatch":false,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Jon Loeliger writes:\n\n> Public apology and brown paper bag. My patch\n> accidentally twiddled the mode on git-pull.sh:\n>\n> mode change 100755 => 100644 git-pull.sh\n\nNo need for worrying things like this. Mistakes and accidents\nhappen.\n\nMakefile installs git-pull with executable bit set anyway, so it\nreally does not matter.\n\n-jc\n"},{"id":"11327","messageId":"20051108163546.GC1431@pasky.or.cz","threadId":"2400","inReplyTo":"7v4q6njecr.fsf@assigned-by-dhcp.cox.net","subject":"Re: git-pull.sh's bad mode","fromName":"Petr Baudis","fromEmail":"pasky@suse.cz","sentAt":"2005-11-08T16:35:46Z","receivedAt":"2005-11-08T16:35:46Z","isPatch":false,"sender":{"key":"pasky@ucw.cz","avatar":"https://avatars.githubusercontent.com/u/18439?v=4"},"body":"Dear diary, on Tue, Nov 08, 2005 at 05:25:56PM CET, I got a letter\nwhere Junio C Hamano told me that...\n> Jon Loeliger writes:\n> \n> > Public apology and brown paper bag. My patch\n> > accidentally twiddled the mode on git-pull.sh:\n> >\n> > mode change 100755 => 100644 git-pull.sh\n> \n> No need for worrying things like this. Mistakes and accidents\n> happen.\n> \n> Makefile installs git-pull with executable bit set anyway, so it\n> really does not matter.\n\nBut it should definitely be fixed. E.g. I actually personally use (for\nCogito development) git-core which I never make install (I have\nsystem-wide git-core installation which is just whatever is the latest\nversion Gentoo ships, and I use that for non-Cogito development).\nIt would be painful if this mode of usage wouldn't be supported.\n\n-- \n\t\t\t\tPetr \"Pasky\" Baudis\nStuff: http://pasky.or.cz/\nVI has two modes: the one in which it beeps and the one in which\nit doesn't.\n"},{"id":"11342","messageId":"7vhdaney4d.fsf@assigned-by-dhcp.cox.net","threadId":"2400","inReplyTo":"20051108163546.GC1431@pasky.or.cz","subject":"Re: git-pull.sh's bad mode","fromName":"Junio C Hamano","fromEmail":"junkio@cox.net","sentAt":"2005-11-08T19:30:10Z","receivedAt":"2005-11-08T19:30:10Z","isPatch":false,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Petr Baudis writes:\n\n>> Makefile installs git-pull with executable bit set anyway, so it\n>> really does not matter.\n>\n> But it should definitely be fixed. E.g. I actually personally use (for\n> Cogito development) git-core which I never make install (I have\n> system-wide git-core installation which is just whatever is the latest\n> version Gentoo ships, and I use that for non-Cogito development).\n> It would be painful if this mode of usage wouldn't be supported.\n\nYou could perhaps do \"make\" without install and set PATH to\ninclude the source directory (you need to do a bit more if we\never update templates/ directory and you would want to try it). \n\nThe point is that git-pull was generated with +x from\ngit-pull.sh, and the mode bits of git-pull.sh (source) does not\nmatter anymore. It used to matter back when we called them\ngit-*-script but not these days.\n"},{"id":"11344","messageId":"20051108193903.GH16512@pasky.or.cz","threadId":"2400","inReplyTo":"7vhdaney4d.fsf@assigned-by-dhcp.cox.net","subject":"Re: git-pull.sh's bad mode","fromName":"Petr Baudis","fromEmail":"pasky@suse.cz","sentAt":"2005-11-08T19:39:03Z","receivedAt":"2005-11-08T19:39:03Z","isPatch":false,"sender":{"key":"pasky@ucw.cz","avatar":"https://avatars.githubusercontent.com/u/18439?v=4"},"body":"Dear diary, on Tue, Nov 08, 2005 at 08:30:10PM CET, I got a letter\nwhere Junio C Hamano told me that...\n> You could perhaps do \"make\" without install and set PATH to\n> include the source directory (you need to do a bit more if we\n> ever update templates/ directory and you would want to try it). \n\nThat's what I do.\n\n> The point is that git-pull was generated with +x from\n> git-pull.sh, and the mode bits of git-pull.sh (source) does not\n> matter anymore. It used to matter back when we called them\n> git-*-script but not these days.\n\nAh so. I see. Well, still useful when I'm changing something and I'm\nlazy to remake after each change. ;-)\n\nEither way, it should be consistent for all the scripts - either +x or\n-x (but yes, definitely not a brown paper bag thing :).\n\n-- \n\t\t\t\tPetr \"Pasky\" Baudis\nStuff: http://pasky.or.cz/\nVI has two modes: the one in which it beeps and the one in which\nit doesn't.\n"}]}