threads / patch / 23747

patchMakefile: Fix 'clean' target to remove all gitweb build files

Subject: [PATCH] Makefile: Fix 'clean' target to remove all gitweb build files

## tl;dr

2 messages between May 8, 2010 and May 8, 2010. Diffs are folded; open one to read it.

replies: 1people: 2as markdown or json

Ramsay Jones· May 8, 2010, 17:36 UTC · lore

In particular the gitweb/GITWEB-BUILD-OPTIONS file was not being removed by the main Makefile. However, the gitweb/Makefile has a 'clean' target that correctly removes all the build products. In order to fix the problem, rather than duplicate the clean-up instructions, we change the main Makefile so that it delegates the clean-up actions to the gitweb Makefile.

Signed-off-by: Ramsay Jones <ramsay@ramsay1.demon.co.uk>
---
 Makefile |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

Show changes to Makefile +1 −1

diff --git a/Makefile b/Makefile
index 910f471..eb1d162 100644
--- a/Makefile
+++ b/Makefile
@@ -2098,7 +2098,7 @@ clean:
 	$(RM) $(htmldocs).tar.gz $(manpages).tar.gz
 	$(MAKE) -C Documentation/ clean
 ifndef NO_PERL
-	$(RM) gitweb/gitweb.cgi gitweb/gitweb.min.*
+	$(MAKE) -C gitweb clean
 	$(MAKE) -C perl clean
 endif
 ifndef NO_PYTHON

-- 
1.7.1

Jakub Narebski· May 8, 2010, 18:07 UTC · re: Ramsay Jones · lore

Re: [PATCH] Makefile: Fix 'clean' target to remove all gitweb build files

Ramsay Jones <ramsay@ramsay1.demon.co.uk> writes:

Show 8 quoted lines

> In particular the gitweb/GITWEB-BUILD-OPTIONS file was not being
> removed by the main Makefile. However, the gitweb/Makefile has a
> 'clean' target that correctly removes all the build products.
> In order to fix the problem, rather than duplicate the clean-up
> instructions, we change the main Makefile so that it delegates
> the clean-up actions to the gitweb Makefile.
> 
> Signed-off-by: Ramsay Jones <ramsay@ramsay1.demon.co.uk>

For what it is worth

Acked-by: Jakub Narebski <jnareb@gmail.com>

Show 19 quoted lines

> ---
>  Makefile |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/Makefile b/Makefile
> index 910f471..eb1d162 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -2098,7 +2098,7 @@ clean:
>  	$(RM) $(htmldocs).tar.gz $(manpages).tar.gz
>  	$(MAKE) -C Documentation/ clean
>  ifndef NO_PERL
> -	$(RM) gitweb/gitweb.cgi gitweb/gitweb.min.*
> +	$(MAKE) -C gitweb clean
>  	$(MAKE) -C perl clean
>  endif
>  ifndef NO_PYTHON
> -- 
> 1.7.1

-- 
Jakub Narebski
Poland
ShadeHawk on #git