{"thread":{"id":"23747","subject":"[PATCH] Makefile: Fix 'clean' target to remove all gitweb build files","startedAt":"2010-05-08T17:36:15Z","lastAt":"2010-05-08T18:07:45Z","messageCount":2,"participants":["Ramsay Jones","Jakub Narebski"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"141255","messageId":"4BE5A10F.6040401@ramsay1.demon.co.uk","threadId":"23747","inReplyTo":null,"subject":"[PATCH] Makefile: Fix 'clean' target to remove all gitweb build files","fromName":"Ramsay Jones","fromEmail":"ramsay@ramsay1.demon.co.uk","sentAt":"2010-05-08T17:36:15Z","receivedAt":"2010-05-08T17:36:15Z","isPatch":true,"sender":{"key":"ramsay@ramsayjones.plus.com","avatar":"https://avatars.githubusercontent.com/u/33702710?v=4"},"body":"\nIn particular the gitweb/GITWEB-BUILD-OPTIONS file was not being\nremoved by the main Makefile. However, the gitweb/Makefile has a\n'clean' target that correctly removes all the build products.\nIn order to fix the problem, rather than duplicate the clean-up\ninstructions, we change the main Makefile so that it delegates\nthe clean-up actions to the gitweb Makefile.\n\nSigned-off-by: Ramsay Jones <ramsay@ramsay1.demon.co.uk>\n---\n Makefile |    2 +-\n 1 files changed, 1 insertions(+), 1 deletions(-)\n\ndiff --git a/Makefile b/Makefile\nindex 910f471..eb1d162 100644\n--- a/Makefile\n+++ b/Makefile\n@@ -2098,7 +2098,7 @@ clean:\n \t$(RM) $(htmldocs).tar.gz $(manpages).tar.gz\n \t$(MAKE) -C Documentation/ clean\n ifndef NO_PERL\n-\t$(RM) gitweb/gitweb.cgi gitweb/gitweb.min.*\n+\t$(MAKE) -C gitweb clean\n \t$(MAKE) -C perl clean\n endif\n ifndef NO_PYTHON\n-- \n1.7.1\n"},{"id":"141258","messageId":"m3fx22e08t.fsf@localhost.localdomain","threadId":"23747","inReplyTo":"4BE5A10F.6040401@ramsay1.demon.co.uk","subject":"Re: [PATCH] Makefile: Fix 'clean' target to remove all gitweb build files","fromName":"Jakub Narebski","fromEmail":"jnareb@gmail.com","sentAt":"2010-05-08T18:07:45Z","receivedAt":"2010-05-08T18:07:45Z","isPatch":true,"sender":{"key":"jnareb@gmail.com","avatar":"https://avatars.githubusercontent.com/u/2706?v=4"},"body":"Ramsay Jones <ramsay@ramsay1.demon.co.uk> writes:\n\n> In particular the gitweb/GITWEB-BUILD-OPTIONS file was not being\n> removed by the main Makefile. However, the gitweb/Makefile has a\n> 'clean' target that correctly removes all the build products.\n> In order to fix the problem, rather than duplicate the clean-up\n> instructions, we change the main Makefile so that it delegates\n> the clean-up actions to the gitweb Makefile.\n> \n> Signed-off-by: Ramsay Jones <ramsay@ramsay1.demon.co.uk>\n\nFor what it is worth\n\nAcked-by: Jakub Narebski <jnareb@gmail.com>\n\n> ---\n>  Makefile |    2 +-\n>  1 files changed, 1 insertions(+), 1 deletions(-)\n> \n> diff --git a/Makefile b/Makefile\n> index 910f471..eb1d162 100644\n> --- a/Makefile\n> +++ b/Makefile\n> @@ -2098,7 +2098,7 @@ clean:\n>  \t$(RM) $(htmldocs).tar.gz $(manpages).tar.gz\n>  \t$(MAKE) -C Documentation/ clean\n>  ifndef NO_PERL\n> -\t$(RM) gitweb/gitweb.cgi gitweb/gitweb.min.*\n> +\t$(MAKE) -C gitweb clean\n>  \t$(MAKE) -C perl clean\n>  endif\n>  ifndef NO_PYTHON\n> -- \n> 1.7.1\n\n-- \nJakub Narebski\nPoland\nShadeHawk on #git\n"}]}