threads / patch / 23746

patchgit-svn: Remove unused use of File::Temp

Subject: [PATCH] git-svn: Remove unused use of File::Temp

## tl;dr

2 messages between May 8, 2010 and May 9, 2010. Diffs are folded; open one to read it.

replies: 1people: 2as markdown or json

Ævar Arnfjörð Bjarmason· May 8, 2010, 16:40 UTC · lore

The use line was added in ffe256f9. File::Temp calls were later moved to Git.pm in 0b19138b, but that commit neglected to remove the now-redundant import.

Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
---
 git-svn.perl |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)

Show changes to git-svn.perl +0 −1

diff --git a/git-svn.perl b/git-svn.perl
index 2c86ea2..cc3a54c 100755
--- a/git-svn.perl
+++ b/git-svn.perl
@@ -3998,7 +3998,6 @@ use vars qw/@ISA/;
 use strict;
 use warnings;
 use Carp qw/croak/;
-use File::Temp qw/tempfile/;
 use IO::File qw//;
 use vars qw/$_ignore_regex/;

-- 
1.7.0.4

Eric Wong· May 9, 2010, 08:31 UTC · re: Ævar Arnfjörð Bjarmason · lore

Re: [PATCH] git-svn: Remove unused use of File::Temp

Ævar Arnfjörð Bjarmason <avarab@gmail.com> wrote:

Show 5 quoted lines

> The use line was added in ffe256f9. File::Temp calls were later moved
> to Git.pm in 0b19138b, but that commit neglected to remove the
> now-redundant import.
> 
> Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>

Thanks,

Acked-by: Eric Wong <normalperson@yhbt.net>

...and pushed out to git://git.bogomips.org/git-svn along with a few others:

Jonathan Nieder (1):
      git svn: avoid uninitialized var in 'reset'

Torsten Schmutzler (1):
      git-svn: mangle refnames forbidden in git

Ævar Arnfjörð Bjarmason (2):
      git-svn documentation: minor grammar fix
      git-svn: Remove unused use of File::Temp

-- 
Eric Wong