# [PATCH] git-svn: Remove unused use of File::Temp

2 messages from 2010-05-08 to 2010-05-09. Participants: Ævar Arnfjörð Bjarmason, Eric Wong.
Thread: https://gitlist.dev/t/23746

## Ævar Arnfjörð Bjarmason, 2010-05-08 16:40

Subject: [PATCH] git-svn: Remove unused use of File::Temp
Message-ID: <1273336841-31461-1-git-send-email-avarab@gmail.com>
URL: https://gitlist.dev/e/1273336841-31461-1-git-send-email-avarab%40gmail.com

```
The use line was added in ffe256f9. File::Temp calls were later moved
to Git.pm in 0b19138b, but that commit neglected to remove the
now-redundant import.

Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
---
 git-svn.perl |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)

diff --git a/git-svn.perl b/git-svn.perl
index 2c86ea2..cc3a54c 100755
--- a/git-svn.perl
+++ b/git-svn.perl
@@ -3998,7 +3998,6 @@ use vars qw/@ISA/;
 use strict;
 use warnings;
 use Carp qw/croak/;
-use File::Temp qw/tempfile/;
 use IO::File qw//;
 use vars qw/$_ignore_regex/;
 
-- 
1.7.0.4

```

## Eric Wong, 2010-05-09 08:31

Subject: Re: [PATCH] git-svn: Remove unused use of File::Temp
Message-ID: <20100509083137.GA12627@dcvr.yhbt.net>
URL: https://gitlist.dev/e/20100509083137.GA12627%40dcvr.yhbt.net
In-Reply-To: <1273336841-31461-1-git-send-email-avarab@gmail.com>

```
Ævar Arnfjörð Bjarmason <avarab@gmail.com> wrote:
> The use line was added in ffe256f9. File::Temp calls were later moved
> to Git.pm in 0b19138b, but that commit neglected to remove the
> now-redundant import.
> 
> Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>

Thanks,

Acked-by: Eric Wong <normalperson@yhbt.net>

...and pushed out to git://git.bogomips.org/git-svn along with a few
others:

Jonathan Nieder (1):
      git svn: avoid uninitialized var in 'reset'

Torsten Schmutzler (1):
      git-svn: mangle refnames forbidden in git

Ævar Arnfjörð Bjarmason (2):
      git-svn documentation: minor grammar fix
      git-svn: Remove unused use of File::Temp

-- 
Eric Wong

```