[PATCH] gitk: moving all three panes if clicking on an arrow.

Stefan-W. Hahn· Nov 5, 2005, 19:55 UTC · lore

[PATCH] gitk: moving all three panes if clicking on an arrow.

Signed-off-by: Stefan-W. Hahn <stefan.hahn@s-hahn.de>

---

 gitk |    4 +++-
 1 files changed, 3 insertions(+), 1 deletions(-)

applies-to: ef3876e50bb5e91a6fb40d4e59df2178c6f40237 078ef4fa295368b5337ad797b27372bbaa19d7fc

Show changes to gitk +3 −1

diff --git a/gitk b/gitk
index a9d37d9..616a3e2 100755
--- a/gitk
+++ b/gitk
@@ -3178,7 +3178,7 @@ proc clickisonarrow {id y} {
 }
 
 proc arrowjump {id dirn y} {
-    global mainline sidelines canv
+    global mainline sidelines canv canv2 canv3
 
     set yt {}
     if {$dirn eq "down"} {
@@ -3216,6 +3216,8 @@ proc arrowjump {id dirn y} {
        set yfrac 0
     }
     $canv yview moveto $yfrac
+    $canv2 yview moveto $yfrac
+    $canv3 yview moveto $yfrac
 }
 
 proc lineclick {x y id isnew} {
---
0.99.8.GIT

-- 
Stefan-W. Hahn                          It is easy to make things.
/ mailto:stefan.hahn@s-hahn.de /        It is hard to make things simple.

Junio C Hamano· Nov 19, 2005, 08:31 UTC · re: Stefan-W. Hahn · lore

Re: [PATCH] gitk: moving all three panes if clicking on an arrow.

"Stefan-W. Hahn" <stefan.hahn@s-hahn.de> writes:

> [PATCH] gitk: moving all three panes if clicking on an arrow.
>
> Signed-off-by: Stefan-W. Hahn <stefan.hahn@s-hahn.de>

Obviously correct and much more pleasant to use.

Acked-by: Junio C Hamano <junkio@cox.net>

Paul, I earlier sent a pull request; I included this patch there as well. So you will find the following four.

commit e3fe532ddce7311cfbbdc98d2e157d33f6275231
Author: Stefan-W. Hahn <stefan.hahn@s-hahn.de>
Date:   Sat Nov 5 20:55:29 2005 +0100

    gitk: moving all three panes if clicking on an arrow.
    
    Signed-off-by: Stefan-W. Hahn <stefan.hahn@s-hahn.de>
    Signed-off-by: Junio C Hamano <junkio@cox.net>

commit fd913b39101c6ff185e76e459479621c9b475fa1
Author: Pavel Roskin <proski@gnu.org>
Date:   Fri Nov 11 10:09:12 2005 -0500

    gitk: use git-diff-tree --no-commit-id
    
    gitk switched to use git-diff-tree with one argument in gettreediffs and
    getblobdiffs.  git-diff-tree with one argument outputs commit ID in from
    of the patch.  This causes an empty line after "Comments" in the lower
    right pane.  Also, the diff in the lower left pane has the commit ID,
    which is useless there.
    
    This patch makes git use the newly added -no-commit-id option for
    git-diff-tree to suppress commit ID.  It also removes the p variable in
    both functions, since it has become useless after switching to the
    one-argument invocation for git-diff-tree.
    
    Signed-off-by: Pavel Roskin <proski@gnu.org>
    Signed-off-by: Junio C Hamano <junkio@cox.net>

commit e246483dc5b56d7deb04a93b0aa08aba4cde0625
Author: Frank Sorenson <frank@tuxrocks.com>
Date:   Sun Oct 30 02:06:46 2005 -0700

    gitk: Specify line hover font
    
    Hovering over a line in gitk displays the commit one-liner in a
    box, but the text usually overflows the box.  The box size is
    computed with a specified font, so this patch sets the text font
    as well.
    
    Signed-off-by: Frank Sorenson <frank@tuxrocks.com>
    Signed-off-by: Junio C Hamano <junkio@cox.net>

commit 36a7cad6e4ae8a331731666d985a7619a76bb4fb
Author: Junio C Hamano <junkio@cox.net>
Date:   Fri Nov 18 23:54:17 2005 -0800

    readrefs: grab all refs with one call to ls-remote.
    
    Instead of reading refs/heads/* and refs/tags/* files ourselves
    and missing files in subdirectories of heads/ and tags/, use
    ls-remote on local repository and grab all of them.  This lets us
    also remove the procedure readotherrefs.
    
    Signed-off-by: Junio C Hamano <junkio@cox.net>

Paul Mackerras· Nov 20, 2005, 10:20 UTC · re: Junio C Hamano · lore

Re: [PATCH] gitk: moving all three panes if clicking on an arrow.

Junio C Hamano writes:

> Paul, I earlier sent a pull request; I included this patch there
> as well.  So you will find the following four.

Thanks, pulled and pushed out.

Regards, Paul.

patchgitk: moving all three panes if clicking on an arrow.