{"thread":{"id":"2359","subject":"[PATCH] gitk: moving all three panes if clicking on an arrow.","startedAt":"2005-11-05T19:55:29Z","lastAt":"2005-11-20T10:20:25Z","messageCount":3,"participants":["Stefan-W. Hahn","Junio C Hamano","Paul Mackerras"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"11173","messageId":"20051105195529.GB6081@scotty.home","threadId":"2359","inReplyTo":null,"subject":"[PATCH] gitk: moving all three panes if clicking on an arrow.","fromName":"Stefan-W. Hahn","fromEmail":"stefan.hahn@s-hahn.de","sentAt":"2005-11-05T19:55:29Z","receivedAt":"2005-11-05T19:55:29Z","isPatch":true,"sender":{"key":"stefan.hahn@s-hahn.de","avatar":null},"body":"[PATCH] gitk: moving all three panes if clicking on an arrow.\n\nSigned-off-by: Stefan-W. Hahn <stefan.hahn@s-hahn.de>\n\n---\n\n gitk |    4 +++-\n 1 files changed, 3 insertions(+), 1 deletions(-)\n\napplies-to: ef3876e50bb5e91a6fb40d4e59df2178c6f40237\n078ef4fa295368b5337ad797b27372bbaa19d7fc\ndiff --git a/gitk b/gitk\nindex a9d37d9..616a3e2 100755\n--- a/gitk\n+++ b/gitk\n@@ -3178,7 +3178,7 @@ proc clickisonarrow {id y} {\n }\n \n proc arrowjump {id dirn y} {\n-    global mainline sidelines canv\n+    global mainline sidelines canv canv2 canv3\n \n     set yt {}\n     if {$dirn eq \"down\"} {\n@@ -3216,6 +3216,8 @@ proc arrowjump {id dirn y} {\n        set yfrac 0\n     }\n     $canv yview moveto $yfrac\n+    $canv2 yview moveto $yfrac\n+    $canv3 yview moveto $yfrac\n }\n \n proc lineclick {x y id isnew} {\n---\n0.99.8.GIT\n\n-- \nStefan-W. Hahn                          It is easy to make things.\n/ mailto:stefan.hahn@s-hahn.de /        It is hard to make things simple.\t\t\t\n"},{"id":"12313","messageId":"7vfyptavik.fsf@assigned-by-dhcp.cox.net","threadId":"2359","inReplyTo":"20051105195529.GB6081@scotty.home","subject":"Re: [PATCH] gitk: moving all three panes if clicking on an arrow.","fromName":"Junio C Hamano","fromEmail":"junkio@cox.net","sentAt":"2005-11-19T08:31:47Z","receivedAt":"2005-11-19T08:31:47Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"\"Stefan-W. Hahn\" <stefan.hahn@s-hahn.de> writes:\n\n> [PATCH] gitk: moving all three panes if clicking on an arrow.\n>\n> Signed-off-by: Stefan-W. Hahn <stefan.hahn@s-hahn.de>\n\nObviously correct and much more pleasant to use.\n\nAcked-by: Junio C Hamano <junkio@cox.net>\n\nPaul, I earlier sent a pull request; I included this patch there\nas well.  So you will find the following four.\n\ncommit e3fe532ddce7311cfbbdc98d2e157d33f6275231\nAuthor: Stefan-W. Hahn <stefan.hahn@s-hahn.de>\nDate:   Sat Nov 5 20:55:29 2005 +0100\n\n    gitk: moving all three panes if clicking on an arrow.\n    \n    Signed-off-by: Stefan-W. Hahn <stefan.hahn@s-hahn.de>\n    Signed-off-by: Junio C Hamano <junkio@cox.net>\n\ncommit fd913b39101c6ff185e76e459479621c9b475fa1\nAuthor: Pavel Roskin <proski@gnu.org>\nDate:   Fri Nov 11 10:09:12 2005 -0500\n\n    gitk: use git-diff-tree --no-commit-id\n    \n    gitk switched to use git-diff-tree with one argument in gettreediffs and\n    getblobdiffs.  git-diff-tree with one argument outputs commit ID in from\n    of the patch.  This causes an empty line after \"Comments\" in the lower\n    right pane.  Also, the diff in the lower left pane has the commit ID,\n    which is useless there.\n    \n    This patch makes git use the newly added -no-commit-id option for\n    git-diff-tree to suppress commit ID.  It also removes the p variable in\n    both functions, since it has become useless after switching to the\n    one-argument invocation for git-diff-tree.\n    \n    Signed-off-by: Pavel Roskin <proski@gnu.org>\n    Signed-off-by: Junio C Hamano <junkio@cox.net>\n\ncommit e246483dc5b56d7deb04a93b0aa08aba4cde0625\nAuthor: Frank Sorenson <frank@tuxrocks.com>\nDate:   Sun Oct 30 02:06:46 2005 -0700\n\n    gitk: Specify line hover font\n    \n    Hovering over a line in gitk displays the commit one-liner in a\n    box, but the text usually overflows the box.  The box size is\n    computed with a specified font, so this patch sets the text font\n    as well.\n    \n    Signed-off-by: Frank Sorenson <frank@tuxrocks.com>\n    Signed-off-by: Junio C Hamano <junkio@cox.net>\n\ncommit 36a7cad6e4ae8a331731666d985a7619a76bb4fb\nAuthor: Junio C Hamano <junkio@cox.net>\nDate:   Fri Nov 18 23:54:17 2005 -0800\n\n    readrefs: grab all refs with one call to ls-remote.\n    \n    Instead of reading refs/heads/* and refs/tags/* files ourselves\n    and missing files in subdirectories of heads/ and tags/, use\n    ls-remote on local repository and grab all of them.  This lets us\n    also remove the procedure readotherrefs.\n    \n    Signed-off-by: Junio C Hamano <junkio@cox.net>\n"},{"id":"12368","messageId":"17280.19945.920598.839612@cargo.ozlabs.ibm.com","threadId":"2359","inReplyTo":"7vfyptavik.fsf@assigned-by-dhcp.cox.net","subject":"Re: [PATCH] gitk: moving all three panes if clicking on an arrow.","fromName":"Paul Mackerras","fromEmail":"paulus@samba.org","sentAt":"2005-11-20T10:20:25Z","receivedAt":"2005-11-20T10:20:25Z","isPatch":true,"sender":{"key":"paulus@samba.org","avatar":"https://avatars.githubusercontent.com/u/1606439?v=4"},"body":"Junio C Hamano writes:\n\n> Paul, I earlier sent a pull request; I included this patch there\n> as well.  So you will find the following four.\n\nThanks, pulled and pushed out.\n\nRegards,\nPaul.\n"}]}