threads / patch / 23225

patchLink against libiconv on IRIX

Subject: [PATCH] Link against libiconv on IRIX

## tl;dr

4 messages between Mar 29, 2010 and Apr 5, 2010. Diffs are folded; open one to read it.

replies: 3people: 4as markdown or json

Holger Weiß· Mar 29, 2010, 10:57 UTC · lore

On IRIX, "-liconv" must be added to the linker command line in order to get iconv(3) support; set the according Makefile variable appropriately.

Signed-off-by: Holger Weiß <holger@zedat.fu-berlin.de>
---
 Makefile |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

Show changes to Makefile +2 −0

diff --git a/Makefile b/Makefile
index 3a6c6ea..8a0f5c4 100644
--- a/Makefile
+++ b/Makefile
@@ -919,6 +919,7 @@ ifeq ($(uname_S),IRIX)
 	SNPRINTF_RETURNS_BOGUS = YesPlease
 	SHELL_PATH = /usr/gnu/bin/bash
 	NEEDS_LIBGEN = YesPlease
+	NEEDS_LIBICONV = YesPlease
 endif
 ifeq ($(uname_S),IRIX64)
 	NO_SETENV=YesPlease
@@ -937,6 +938,7 @@ ifeq ($(uname_S),IRIX64)
 	SNPRINTF_RETURNS_BOGUS = YesPlease
 	SHELL_PATH=/usr/gnu/bin/bash
 	NEEDS_LIBGEN = YesPlease
+	NEEDS_LIBICONV = YesPlease
 endif
 ifeq ($(uname_S),HP-UX)
 	NO_IPV6=YesPlease

-- 
1.7.0.3

Brandon Casey· Apr 5, 2010, 16:45 UTC · re: Holger Weiß · lore

Re: [PATCH] Link against libiconv on IRIX

On 03/29/2010 05:57 AM, Holger Weiß wrote:

> On IRIX, "-liconv" must be added to the linker command line in order to
> get iconv(3) support; set the according Makefile variable appropriately.

This breaks compilation on IRIX 6.5.29m for me since there is no separate libiconv.so.

What version of IRIX are you using?

On my system, even the iconv utility doesn't link against a libiconv shared object. It seems the iconv functionality is in libc.

   # ldd /usr/bin/iconv
           libc.so.1  =>    /usr/lib32/libc.so.1

Could it be that you are using a third party iconv library? I've experienced this on another system and the problem was related to curl. In that case, curl was linked against an external iconv and not the native library, so if I tried to build with curl support, I had to also build against the external iconv library.

-brandon

Show 25 quoted lines

> Signed-off-by: Holger Weiß <holger@zedat.fu-berlin.de>
> ---
>  Makefile |    2 ++
>  1 files changed, 2 insertions(+), 0 deletions(-)
> 
> diff --git a/Makefile b/Makefile
> index 3a6c6ea..8a0f5c4 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -919,6 +919,7 @@ ifeq ($(uname_S),IRIX)
>  	SNPRINTF_RETURNS_BOGUS = YesPlease
>  	SHELL_PATH = /usr/gnu/bin/bash
>  	NEEDS_LIBGEN = YesPlease
> +	NEEDS_LIBICONV = YesPlease
>  endif
>  ifeq ($(uname_S),IRIX64)
>  	NO_SETENV=YesPlease
> @@ -937,6 +938,7 @@ ifeq ($(uname_S),IRIX64)
>  	SNPRINTF_RETURNS_BOGUS = YesPlease
>  	SHELL_PATH=/usr/gnu/bin/bash
>  	NEEDS_LIBGEN = YesPlease
> +	NEEDS_LIBICONV = YesPlease
>  endif
>  ifeq ($(uname_S),HP-UX)
>  	NO_IPV6=YesPlease

Junio C Hamano· Apr 5, 2010, 17:15 UTC · re: Brandon Casey · lore

Re: [PATCH] Link against libiconv on IRIX

Thanks for the report.

In the meantime I'll revert 2170422 (Link against libiconv on IRIX, 2010-03-29) and wait for an improved, probably a conditional, change.

Holger Weiß· Apr 5, 2010, 19:44 UTC · re: Brandon Casey · lore

Re: [PATCH] Link against libiconv on IRIX

* Brandon Casey <brandon.casey.ctr@nrlssc.navy.mil> [2010-04-05 11:45]:

Show 5 quoted lines

> Could it be that you are using a third party iconv library?
> I've experienced this on another system and the problem was related
> to curl.  In that case, curl was linked against an external iconv and
> not the native library, so if I tried to build with curl support, I had
> to also build against the external iconv library.

This was exactly the problem in our case, too. I'm sorry for the incorrect patch.

Holger