{"thread":{"id":"23225","subject":"[PATCH] Link against libiconv on IRIX","startedAt":"2010-03-29T10:57:48Z","lastAt":"2010-04-05T19:44:54Z","messageCount":4,"participants":["Holger Weiß","Brandon Casey","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"138068","messageId":"20100329105748.GD14869@CIS.FU-Berlin.DE","threadId":"23225","inReplyTo":null,"subject":"[PATCH] Link against libiconv on IRIX","fromName":"Holger Weiß","fromEmail":"holger@zedat.fu-berlin.de","sentAt":"2010-03-29T10:57:48Z","receivedAt":"2010-03-29T10:57:48Z","isPatch":true,"sender":{"key":"holger@zedat.fu-berlin.de","avatar":"https://avatars.githubusercontent.com/u/71850?v=4"},"body":"On IRIX, \"-liconv\" must be added to the linker command line in order to\nget iconv(3) support; set the according Makefile variable appropriately.\n\nSigned-off-by: Holger Weiß <holger@zedat.fu-berlin.de>\n---\n Makefile |    2 ++\n 1 files changed, 2 insertions(+), 0 deletions(-)\n\ndiff --git a/Makefile b/Makefile\nindex 3a6c6ea..8a0f5c4 100644\n--- a/Makefile\n+++ b/Makefile\n@@ -919,6 +919,7 @@ ifeq ($(uname_S),IRIX)\n \tSNPRINTF_RETURNS_BOGUS = YesPlease\n \tSHELL_PATH = /usr/gnu/bin/bash\n \tNEEDS_LIBGEN = YesPlease\n+\tNEEDS_LIBICONV = YesPlease\n endif\n ifeq ($(uname_S),IRIX64)\n \tNO_SETENV=YesPlease\n@@ -937,6 +938,7 @@ ifeq ($(uname_S),IRIX64)\n \tSNPRINTF_RETURNS_BOGUS = YesPlease\n \tSHELL_PATH=/usr/gnu/bin/bash\n \tNEEDS_LIBGEN = YesPlease\n+\tNEEDS_LIBICONV = YesPlease\n endif\n ifeq ($(uname_S),HP-UX)\n \tNO_IPV6=YesPlease\n-- \n1.7.0.3\n"},{"id":"138602","messageId":"1UypQMCHLT57SnjSQIM66RTkLalsvavG8xXoQJv4rEQ@cipher.nrlssc.navy.mil","threadId":"23225","inReplyTo":"20100329105748.GD14869@CIS.FU-Berlin.DE","subject":"Re: [PATCH] Link against libiconv on IRIX","fromName":"Brandon Casey","fromEmail":"brandon.casey.ctr@nrlssc.navy.mil","sentAt":"2010-04-05T16:45:32Z","receivedAt":"2010-04-05T16:45:32Z","isPatch":true,"sender":{"key":"brandon.casey.ctr@nrlssc.navy.mil","avatar":null},"body":"On 03/29/2010 05:57 AM, Holger Weiß wrote:\n> On IRIX, \"-liconv\" must be added to the linker command line in order to\n> get iconv(3) support; set the according Makefile variable appropriately.\n\nThis breaks compilation on IRIX 6.5.29m for me since there\nis no separate libiconv.so.\n\nWhat version of IRIX are you using?\n\nOn my system, even the iconv utility doesn't link against\na libiconv shared object.  It seems the iconv functionality is in libc.\n\n   # ldd /usr/bin/iconv\n           libc.so.1  =>    /usr/lib32/libc.so.1\n\nCould it be that you are using a third party iconv library?\nI've experienced this on another system and the problem was related\nto curl.  In that case, curl was linked against an external iconv and\nnot the native library, so if I tried to build with curl support, I had\nto also build against the external iconv library.\n\n-brandon\n\n\n> Signed-off-by: Holger Weiß <holger@zedat.fu-berlin.de>\n> ---\n>  Makefile |    2 ++\n>  1 files changed, 2 insertions(+), 0 deletions(-)\n> \n> diff --git a/Makefile b/Makefile\n> index 3a6c6ea..8a0f5c4 100644\n> --- a/Makefile\n> +++ b/Makefile\n> @@ -919,6 +919,7 @@ ifeq ($(uname_S),IRIX)\n>  \tSNPRINTF_RETURNS_BOGUS = YesPlease\n>  \tSHELL_PATH = /usr/gnu/bin/bash\n>  \tNEEDS_LIBGEN = YesPlease\n> +\tNEEDS_LIBICONV = YesPlease\n>  endif\n>  ifeq ($(uname_S),IRIX64)\n>  \tNO_SETENV=YesPlease\n> @@ -937,6 +938,7 @@ ifeq ($(uname_S),IRIX64)\n>  \tSNPRINTF_RETURNS_BOGUS = YesPlease\n>  \tSHELL_PATH=/usr/gnu/bin/bash\n>  \tNEEDS_LIBGEN = YesPlease\n> +\tNEEDS_LIBICONV = YesPlease\n>  endif\n>  ifeq ($(uname_S),HP-UX)\n>  \tNO_IPV6=YesPlease\n"},{"id":"138603","messageId":"7vfx39q0q8.fsf@alter.siamese.dyndns.org","threadId":"23225","inReplyTo":"1UypQMCHLT57SnjSQIM66RTkLalsvavG8xXoQJv4rEQ@cipher.nrlssc.navy.mil","subject":"Re: [PATCH] Link against libiconv on IRIX","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2010-04-05T17:15:59Z","receivedAt":"2010-04-05T17:15:59Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Thanks for the report.\n\nIn the meantime I'll revert 2170422 (Link against libiconv on IRIX,\n2010-03-29) and wait for an improved, probably a conditional, change.\n"},{"id":"138665","messageId":"20100405194454.GA3808951@CIS.FU-Berlin.DE","threadId":"23225","inReplyTo":"1UypQMCHLT57SnjSQIM66RTkLalsvavG8xXoQJv4rEQ@cipher.nrlssc.navy.mil","subject":"Re: [PATCH] Link against libiconv on IRIX","fromName":"Holger Weiß","fromEmail":"holger@cis.fu-berlin.de","sentAt":"2010-04-05T19:44:54Z","receivedAt":"2010-04-05T19:44:54Z","isPatch":true,"sender":{"key":"holger@cis.fu-berlin.de","avatar":null},"body":"* Brandon Casey <brandon.casey.ctr@nrlssc.navy.mil> [2010-04-05 11:45]:\n> Could it be that you are using a third party iconv library?\n> I've experienced this on another system and the problem was related\n> to curl.  In that case, curl was linked against an external iconv and\n> not the native library, so if I tried to build with curl support, I had\n> to also build against the external iconv library.\n\nThis was exactly the problem in our case, too.  I'm sorry for the\nincorrect patch.\n\nHolger\n"}]}