threads / patch / 22650

patchfix minor memory leak in get_tree_entry()

Subject: [PATCH] fix minor memory leak in get_tree_entry()

## tl;dr

2 messages between Feb 14, 2010 and Feb 15, 2010. Diffs are folded; open one to read it.

replies: 1people: 2as markdown or json

René Scharfe· Feb 14, 2010, 09:56 UTC · lore

Signed-off-by: Rene Scharfe <rene.scharfe@lsrfire.ath.cx>
---
 tree-walk.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

Show changes to tree-walk.c +1 −0

diff --git a/tree-walk.c b/tree-walk.c
index 08796c2..67a9a0c 100644
--- a/tree-walk.c
+++ b/tree-walk.c
@@ -441,6 +441,7 @@ int get_tree_entry(const unsigned char *tree_sha1, const char *name, unsigned ch
 
 	if (name[0] == '\0') {
 		hashcpy(sha1, root);
+		free(tree);
 		return 0;
 	}

-- 
1.7.0

Jeff King· Feb 15, 2010, 04:43 UTC · re: René Scharfe · lore

Re: [PATCH] fix minor memory leak in get_tree_entry()

On Sun, Feb 14, 2010 at 10:56:46AM +0100, René Scharfe wrote:

Show 11 quoted lines

> diff --git a/tree-walk.c b/tree-walk.c
> index 08796c2..67a9a0c 100644
> --- a/tree-walk.c
> +++ b/tree-walk.c
> @@ -441,6 +441,7 @@ int get_tree_entry(const unsigned char *tree_sha1, const char *name, unsigned ch
>  
>  	if (name[0] == '\0') {
>  		hashcpy(sha1, root);
> +		free(tree);
>  		return 0;
>  	}

Oops. Good catch.

Acked-by: Jeff King <peff@peff.net>

-Peff