# [PATCH] fix minor memory leak in get_tree_entry() 2 messages from 2010-02-14 to 2010-02-15. Participants: René Scharfe, Jeff King. Thread: https://gitlist.dev/t/22650 ## René Scharfe, 2010-02-14 09:56 Subject: [PATCH] fix minor memory leak in get_tree_entry() Message-ID: <4B77C8DE.5070503@lsrfire.ath.cx> URL: https://gitlist.dev/e/4B77C8DE.5070503%40lsrfire.ath.cx ``` Signed-off-by: Rene Scharfe --- tree-walk.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/tree-walk.c b/tree-walk.c index 08796c2..67a9a0c 100644 --- a/tree-walk.c +++ b/tree-walk.c @@ -441,6 +441,7 @@ int get_tree_entry(const unsigned char *tree_sha1, const char *name, unsigned ch if (name[0] == '\0') { hashcpy(sha1, root); + free(tree); return 0; } -- 1.7.0 ``` ## Jeff King, 2010-02-15 04:43 Subject: Re: [PATCH] fix minor memory leak in get_tree_entry() Message-ID: <20100215044349.GB3336@coredump.intra.peff.net> URL: https://gitlist.dev/e/20100215044349.GB3336%40coredump.intra.peff.net In-Reply-To: <4B77C8DE.5070503@lsrfire.ath.cx> ``` On Sun, Feb 14, 2010 at 10:56:46AM +0100, René Scharfe wrote: > diff --git a/tree-walk.c b/tree-walk.c > index 08796c2..67a9a0c 100644 > --- a/tree-walk.c > +++ b/tree-walk.c > @@ -441,6 +441,7 @@ int get_tree_entry(const unsigned char *tree_sha1, const char *name, unsigned ch > > if (name[0] == '\0') { > hashcpy(sha1, root); > + free(tree); > return 0; > } Oops. Good catch. Acked-by: Jeff King -Peff ```