threads / patch / 22254

patchident.c: suppress fprintf compiler warning

Subject: [PATCH] ident.c: suppress fprintf compiler warning

## tl;dr

One message between Jan 17, 2010 and Jan 17, 2010. Diffs are folded; open one to read it.

replies: 0people: 1as markdown or json

Tarmigan Casebolt· Jan 17, 2010, 06:16 UTC · lore
Compiling today's pu gave
    ...
    CC ident.o
    CC levenshtein.o
ident.c: In function 'fmt_ident':
ident.c:206: warning: format not a string literal and no format arguments
    CC list-objects.o
    ...

This warning seems to have appeared first in 18e95f279ec6 (ident.c: remove unused variables) which removed additional fprintf arguments.

Suppress this warning by using a literal "%s" to print the string instead of passing the string directly to fprintf.

Signed-off-by: Tarmigan Casebolt <tarmigan+git@gmail.com>
---
 ident.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
Show changes to ident.c +1 −1
diff --git a/ident.c b/ident.c
index d4f6145..239112c 100644
--- a/ident.c
+++ b/ident.c
@@ -203,7 +203,7 @@ const char *fmt_ident(const char *name, const char *email,
 
 		if ((warn_on_no_name || error_on_no_name) &&
 		    name == git_default_name && env_hint) {
-			fprintf(stderr, env_hint);
+			fprintf(stderr, "%s", env_hint);
 			env_hint = NULL; /* warn only once */
 		}
 		if (error_on_no_name)
-- 
1.6.6.425.g6b174

← back to recent threads