{"thread":{"id":"22254","subject":"[PATCH] ident.c: suppress fprintf compiler warning","startedAt":"2010-01-17T06:16:14Z","lastAt":"2010-01-17T06:16:14Z","messageCount":1,"participants":["Tarmigan Casebolt"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"131923","messageId":"1263708974-99619-1-git-send-email-tarmigan+git@gmail.com","threadId":"22254","inReplyTo":null,"subject":"[PATCH] ident.c: suppress fprintf compiler warning","fromName":"Tarmigan Casebolt","fromEmail":"tarmigan+git@gmail.com","sentAt":"2010-01-17T06:16:14Z","receivedAt":"2010-01-17T06:16:14Z","isPatch":true,"sender":{"key":"tarmigan+git@gmail.com","avatar":null},"body":"Compiling today's pu gave\n    ...\n    CC ident.o\n    CC levenshtein.o\nident.c: In function 'fmt_ident':\nident.c:206: warning: format not a string literal and no format arguments\n    CC list-objects.o\n    ...\n\nThis warning seems to have appeared first in 18e95f279ec6 (ident.c:\nremove unused variables) which removed additional fprintf arguments.\n\nSuppress this warning by using a literal \"%s\" to print the string\ninstead of passing the string directly to fprintf.\n\nSigned-off-by: Tarmigan Casebolt <tarmigan+git@gmail.com>\n---\n ident.c |    2 +-\n 1 files changed, 1 insertions(+), 1 deletions(-)\n\ndiff --git a/ident.c b/ident.c\nindex d4f6145..239112c 100644\n--- a/ident.c\n+++ b/ident.c\n@@ -203,7 +203,7 @@ const char *fmt_ident(const char *name, const char *email,\n \n \t\tif ((warn_on_no_name || error_on_no_name) &&\n \t\t    name == git_default_name && env_hint) {\n-\t\t\tfprintf(stderr, env_hint);\n+\t\t\tfprintf(stderr, \"%s\", env_hint);\n \t\t\tenv_hint = NULL; /* warn only once */\n \t\t}\n \t\tif (error_on_no_name)\n-- \n1.6.6.425.g6b174\n"}]}