threads / discuss / 22184

[BUGFIX] Unbork remote helper execution

Subject: [BUGFIX] Unbork remote helper execution

## tl;dr

One message between Jan 12, 2010 and Jan 12, 2010.

replies: 0people: 1as markdown or json

Ilari Liusvaara· Jan 12, 2010, 18:49 UTC · lore

Someone that obiviously didn't test the change did the following (the code blames to me, but I didn't write this):

code = start_command(helper);
if (code < 0 && errno == ENOENT)
	die("Unable to find remote helper for '%s'", data->name);
else
	exit(code);
Which is obiviously wrong. The code shouldn't exit if code is 0.
Signed-off-by: Ilari Liusvaara <ilari.liusvaara@elisanet.fi>
---
 transport-helper.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/transport-helper.c b/transport-helper.c
index fece6d6..7012101 100644
--- a/transport-helper.c
+++ b/transport-helper.c
@@ -121,7 +121,7 @@ static struct child_process *get_helper(struct transport *transport)
 	code = start_command(helper);
 	if (code < 0 && errno == ENOENT)
 		die("Unable to find remote helper for '%s'", data->name);
-	else
+	else if (code != 0)
 		exit(code);
 
 	data->helper = helper;
-- 
1.6.6.102.gd6f8f.dirty

← back to recent threads