{"thread":{"id":"22184","subject":"[BUGFIX] Unbork remote helper execution","startedAt":"2010-01-12T18:49:17Z","lastAt":"2010-01-12T18:49:17Z","messageCount":1,"participants":["Ilari Liusvaara"],"isPatch":false,"patchVersion":null,"patchTotal":null},"messages":[{"id":"131400","messageId":"1263322157-21354-1-git-send-email-ilari.liusvaara@elisanet.fi","threadId":"22184","inReplyTo":null,"subject":"[BUGFIX] Unbork remote helper execution","fromName":"Ilari Liusvaara","fromEmail":"ilari.liusvaara@elisanet.fi","sentAt":"2010-01-12T18:49:17Z","receivedAt":"2010-01-12T18:49:17Z","isPatch":false,"sender":{"key":"ilari.liusvaara@elisanet.fi","avatar":null},"body":"Someone that obiviously didn't test the change did the following (the\ncode blames to me, but I didn't write this):\n\ncode = start_command(helper);\nif (code < 0 && errno == ENOENT)\n\tdie(\"Unable to find remote helper for '%s'\", data->name);\nelse\n\texit(code);\n\nWhich is obiviously wrong. The code shouldn't exit if code is 0.\n\nSigned-off-by: Ilari Liusvaara <ilari.liusvaara@elisanet.fi>\n---\n transport-helper.c |    2 +-\n 1 files changed, 1 insertions(+), 1 deletions(-)\n\ndiff --git a/transport-helper.c b/transport-helper.c\nindex fece6d6..7012101 100644\n--- a/transport-helper.c\n+++ b/transport-helper.c\n@@ -121,7 +121,7 @@ static struct child_process *get_helper(struct transport *transport)\n \tcode = start_command(helper);\n \tif (code < 0 && errno == ENOENT)\n \t\tdie(\"Unable to find remote helper for '%s'\", data->name);\n-\telse\n+\telse if (code != 0)\n \t\texit(code);\n \n \tdata->helper = helper;\n-- \n1.6.6.102.gd6f8f.dirty\n"}]}