threads / patch / 22063

patchbranch: die explicitly why when calling "git branch [-a|-r] branchname".

Subject: [PATCH] branch: die explicitly why when calling "git branch [-a|-r] branchname".

## tl;dr

2 messages between Dec 30, 2009 and Dec 31, 2009. Diffs are folded; open one to read it.

replies: 1people: 2as markdown or json

Matthieu Moy· Dec 30, 2009, 14:45 UTC · lore
The -a and -r options used to be silently ignored in such a command.
Signed-off-by: Matthieu Moy <Matthieu.Moy@imag.fr>
---
 builtin-branch.c |    7 +++++--
 1 files changed, 5 insertions(+), 2 deletions(-)
Show changes to builtin-branch.c +5 −2
diff --git a/builtin-branch.c b/builtin-branch.c
index c87e63b..8aef2bb 100644
--- a/builtin-branch.c
+++ b/builtin-branch.c
@@ -638,10 +638,13 @@ int cmd_branch(int argc, const char **argv, const char *prefix)
 		rename_branch(head, argv[0], rename > 1);
 	else if (rename && (argc == 2))
 		rename_branch(argv[0], argv[1], rename > 1);
-	else if (argc <= 2)
+	else if (argc <= 2) {
+		if (kinds != REF_LOCAL_BRANCH) {
+			die("-a and -r options to 'git branch' do not make sense with a branch name");
+		}
 		create_branch(head, argv[0], (argc == 2) ? argv[1] : head,
 			      force_create, reflog, track);
-	else
+	} else
 		usage_with_options(builtin_branch_usage, options);
 
 	return 0;
-- 
1.6.6.71.gcc720.dirty
Junio C Hamano· Dec 31, 2009, 23:09 UTC · re: Matthieu Moy · lore

Re: [PATCH] branch: die explicitly why when calling "git branch [-a|-r] branchname".

Thanks; will apply to 'maint', together with the SubmittingPatches addition.

Interestingly, this revealed a long-standing breakage in t5403.

← back to recent threads