# [PATCH] branch: die explicitly why when calling "git branch [-a|-r] branchname". 2 messages from 2009-12-30 to 2009-12-31. Participants: Matthieu Moy, Junio C Hamano. Thread: https://gitlist.dev/t/22063 ## Matthieu Moy, 2009-12-30 14:45 Subject: [PATCH] branch: die explicitly why when calling "git branch [-a|-r] branchname". Message-ID: <1262184331-9102-1-git-send-email-Matthieu.Moy@imag.fr> URL: https://gitlist.dev/e/1262184331-9102-1-git-send-email-Matthieu.Moy%40imag.fr ``` The -a and -r options used to be silently ignored in such a command. Signed-off-by: Matthieu Moy --- builtin-branch.c | 7 +++++-- 1 files changed, 5 insertions(+), 2 deletions(-) diff --git a/builtin-branch.c b/builtin-branch.c index c87e63b..8aef2bb 100644 --- a/builtin-branch.c +++ b/builtin-branch.c @@ -638,10 +638,13 @@ int cmd_branch(int argc, const char **argv, const char *prefix) rename_branch(head, argv[0], rename > 1); else if (rename && (argc == 2)) rename_branch(argv[0], argv[1], rename > 1); - else if (argc <= 2) + else if (argc <= 2) { + if (kinds != REF_LOCAL_BRANCH) { + die("-a and -r options to 'git branch' do not make sense with a branch name"); + } create_branch(head, argv[0], (argc == 2) ? argv[1] : head, force_create, reflog, track); - else + } else usage_with_options(builtin_branch_usage, options); return 0; -- 1.6.6.71.gcc720.dirty ``` ## Junio C Hamano, 2009-12-31 23:09 Subject: Re: [PATCH] branch: die explicitly why when calling "git branch [-a|-r] branchname". Message-ID: <7vaawyrban.fsf@alter.siamese.dyndns.org> URL: https://gitlist.dev/e/7vaawyrban.fsf%40alter.siamese.dyndns.org In-Reply-To: <1262184331-9102-1-git-send-email-Matthieu.Moy@imag.fr> ``` Thanks; will apply to 'maint', together with the SubmittingPatches addition. Interestingly, this revealed a long-standing breakage in t5403. ```