threads / discuss / 20434

Newbie patch question

Subject: Newbie patch question

## tl;dr

3 messages between Aug 6, 2009 and Aug 6, 2009.

replies: 2people: 3as markdown or json

Luke Diamand· Aug 6, 2009, 12:54 UTC · lore

Hi!

I submitted a patch a while back to speed up git-p4. What steps should I take next to move it on? Did I submit the patch wrong in the first place?

http://thread.gmane.org/gmane.comp.version-control.git/124410

Thanks Luke

Matthieu Moy· Aug 6, 2009, 13:13 UTC · re: Luke Diamand · lore

Re: Newbie patch question

Luke Diamand <luke@diamand.org> writes:

Show 5 quoted lines

> Hi!
>
> I submitted a patch a while back to speed up git-p4. What steps should
> I take next to move it on? Did I submit the patch wrong in the first
> place?

Two hints (I didn't follow your patch in particular):

Read Documentation/SubmittingPatches if not done already.

Read the "What's in git.git" and "What's cooking in git.git" messages on this list and the threads below your patch to know what's going on with it.

-- 
Matthieu

Junio C Hamano· Aug 6, 2009, 19:24 UTC · re: Luke Diamand · lore

Re: Newbie patch question

Luke Diamand <luke@diamand.org> writes:

Show 5 quoted lines

> I submitted a patch a while back to speed up git-p4. What steps should
> I take next to move it on? Did I submit the patch wrong in the first
> place?
>
> http://thread.gmane.org/gmane.comp.version-control.git/124410

You didn't do anything wrong at all.  I still have the patch in my Inbox.

I was waiting to see an Ack, independent success reports and such. As I do not interract with p4 myself at all, I wouldn't be able to judge patches to p4 area (and contrib/ in general) without help from others.