# Newbie patch question 3 messages from 2009-08-06 to 2009-08-06. Participants: Luke Diamand, Matthieu Moy, Junio C Hamano. Thread: https://gitlist.dev/t/20434 ## Luke Diamand, 2009-08-06 12:54 Subject: Newbie patch question Message-ID: <396c099f0908060554i34dc74dfubcfec89735a98833@mail.gmail.com> URL: https://gitlist.dev/e/396c099f0908060554i34dc74dfubcfec89735a98833%40mail.gmail.com ``` Hi! I submitted a patch a while back to speed up git-p4. What steps should I take next to move it on? Did I submit the patch wrong in the first place? http://thread.gmane.org/gmane.comp.version-control.git/124410 Thanks Luke ``` ## Matthieu Moy, 2009-08-06 13:13 Subject: Re: Newbie patch question Message-ID: URL: https://gitlist.dev/e/vpq4osl2ih0.fsf%40bauges.imag.fr In-Reply-To: <396c099f0908060554i34dc74dfubcfec89735a98833@mail.gmail.com> ``` Luke Diamand writes: > Hi! > > I submitted a patch a while back to speed up git-p4. What steps should > I take next to move it on? Did I submit the patch wrong in the first > place? Two hints (I didn't follow your patch in particular): Read Documentation/SubmittingPatches if not done already. Read the "What's in git.git" and "What's cooking in git.git" messages on this list and the threads below your patch to know what's going on with it. -- Matthieu ``` ## Junio C Hamano, 2009-08-06 19:24 Subject: Re: Newbie patch question Message-ID: <7vr5vokanz.fsf@alter.siamese.dyndns.org> URL: https://gitlist.dev/e/7vr5vokanz.fsf%40alter.siamese.dyndns.org In-Reply-To: <396c099f0908060554i34dc74dfubcfec89735a98833@mail.gmail.com> ``` Luke Diamand writes: > I submitted a patch a while back to speed up git-p4. What steps should > I take next to move it on? Did I submit the patch wrong in the first > place? > > http://thread.gmane.org/gmane.comp.version-control.git/124410 You didn't do anything wrong at all. I still have the patch in my Inbox. I was waiting to see an Ack, independent success reports and such. As I do not interract with p4 myself at all, I wouldn't be able to judge patches to p4 area (and contrib/ in general) without help from others. ```