threads / patch / 20419

patchconfig.py: fix unset

Subject: [StGit BUG/PATCH] config.py: fix unset

## tl;dr

One message between Aug 6, 2009 and Aug 6, 2009. Diffs are folded; open one to read it.

replies: 0people: 1as markdown or json

Chris Packham· Aug 6, 2009, 03:29 UTC · lore
From: Chris Packham <judge.packham@gmail.com>

Missing invocation of .run() so config.unset('blah') didn't do anything. Consequently the fact that the next line set the value to 'None' instead of a list with 1 element i.e. '[None]' was not noticed.

Signed-off-by: Chris Packham <judge.packham@gmail.com>
---
 stgit/config.py |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
Show changes to stgit/config.py +2 −2
diff --git a/stgit/config.py b/stgit/config.py
index 4a6cb3b..6f84b10 100644
--- a/stgit/config.py
+++ b/stgit/config.py
@@ -94,8 +94,8 @@ class GitConfig:
        self.__cache[name] = value

    def unset(self, name):
-        Run('git', 'config', '--unset', name)
-        self.__cache[name] = None
+        Run('git', 'config', '--unset', name).run()
+        self.__cache[name] = [None]

    def sections_matching(self, regexp):
        """Takes a regexp with a single group, matches it against all

← back to recent threads