{"thread":{"id":"20419","subject":"[StGit BUG/PATCH] config.py: fix unset","startedAt":"2009-08-06T03:29:28Z","lastAt":"2009-08-06T03:29:28Z","messageCount":1,"participants":["Chris Packham"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"119734","messageId":"a038bef50908052029t3e993fcaw75e9a58e120c0c74@mail.gmail.com","threadId":"20419","inReplyTo":null,"subject":"[StGit BUG/PATCH] config.py: fix unset","fromName":"Chris Packham","fromEmail":"judge.packham@gmail.com","sentAt":"2009-08-06T03:29:28Z","receivedAt":"2009-08-06T03:29:28Z","isPatch":true,"sender":{"key":"judge.packham@gmail.com","avatar":"https://avatars.githubusercontent.com/u/155667?v=4"},"body":"From: Chris Packham <judge.packham@gmail.com>\n\nMissing invocation of .run() so config.unset('blah') didn't do anything.\nConsequently the fact that the next line set the value to 'None' instead of a\nlist with 1 element i.e. '[None]' was not noticed.\n\nSigned-off-by: Chris Packham <judge.packham@gmail.com>\n---\n stgit/config.py |    4 ++--\n 1 files changed, 2 insertions(+), 2 deletions(-)\n\ndiff --git a/stgit/config.py b/stgit/config.py\nindex 4a6cb3b..6f84b10 100644\n--- a/stgit/config.py\n+++ b/stgit/config.py\n@@ -94,8 +94,8 @@ class GitConfig:\n        self.__cache[name] = value\n\n    def unset(self, name):\n-        Run('git', 'config', '--unset', name)\n-        self.__cache[name] = None\n+        Run('git', 'config', '--unset', name).run()\n+        self.__cache[name] = [None]\n\n    def sections_matching(self, regexp):\n        \"\"\"Takes a regexp with a single group, matches it against all\n"}]}