Re: [EGIT PATCH2/2] fixed-toString-for-CommitTimeRevFilter-wrote-JUnit-tests

Mark Struberg· Jun 17, 2009, 07:58 UTC · lore

Thanks Robin!

I'm currently working on a larger change by introducing a SimpleRepository class [1] which wraps most of the jgit interna for easier use in external projects, mainly maven-scm-provider-jgit [2]. Since this isn't yet ready to be merged into master as a whole, I had to chop the commits later. This is the reason why the subject doesn't perfectly fit, apologise.

LieGrue, strub

[1] http://github.com/sonatype/JGit/tree/72dd9d071ce140f267b8b4effd34d122627135e6/org.spearce.jgit/src/org/spearce/jgit/simple [2] http://github.com/struberg/maven-scm-providers-git

--- Robin Rosenberg <robin.rosenberg.lists@dewire.com> schrieb am Mi, 17.6.2009:

Show 30 quoted lines

> Von: Robin Rosenberg <robin.rosenberg.lists@dewire.com>
> Betreff: Re: [EGIT PATCH2/2] fixed-toString-for-CommitTimeRevFilter-wrote-JUnit-tests
> An: "Mark Struberg" <struberg@yahoo.de>
> CC: git@vger.kernel.org, "Shawn O. Pearce" <spearce@spearce.org>
> Datum: Mittwoch, 17. Juni 2009, 0:19
> måndag 15 juni 2009 23:36:35 skrev
> Mark Struberg <struberg@yahoo.de>:
> > 
> > From 72dd9d071ce140f267b8b4effd34d122627135e6 Mon Sep
> 17 00:00:00 2001
> > From: Mark Struberg <struberg@yahoo.de>
> > Date: Mon, 15 Jun 2009 08:07:53 +0200
> > Subject: [PATCH] fixed toString for
> CommitTimeRevFilter + wrote JUnit tests for after, before
> and between walks
> 
> What is the connection between the toString and the rest of
> the patch? Should be
> separate patches.
> 
> You should sign off the patches.
> 
> Start the subject with a capital letter.
> 
> Technically it seemed ok, but I shouldn't have pushed them,
> as I did, by mistake when pusing
> Shawn's latest patch. The formal errors should have been
> fixed firsts.
> 
> -- robin