{"thread":{"id":"19836","subject":"Re: [EGIT PATCH2/2] fixed-toString-for-CommitTimeRevFilter-wrote-JUnit-tests","startedAt":"2009-06-17T07:58:51Z","lastAt":"2009-06-17T07:58:51Z","messageCount":1,"participants":["Mark Struberg"],"isPatch":false,"patchVersion":null,"patchTotal":null},"messages":[{"id":"116457","messageId":"324918.80855.qm@web27805.mail.ukl.yahoo.com","threadId":"19836","inReplyTo":null,"subject":"Re: [EGIT PATCH2/2] fixed-toString-for-CommitTimeRevFilter-wrote-JUnit-tests","fromName":"Mark Struberg","fromEmail":"struberg@yahoo.de","sentAt":"2009-06-17T07:58:51Z","receivedAt":"2009-06-17T07:58:51Z","isPatch":false,"sender":{"key":"struberg@yahoo.de","avatar":"https://gravatar.com/avatar/119742c3e8dbc8db35a92bdff0581aec8d364d415f770e60431cba262daa974f?d=mp&s=160"},"body":"\nThanks Robin!\n\nI'm currently working on a larger change by introducing a SimpleRepository class [1] which wraps most of the jgit interna for easier use in external projects, mainly maven-scm-provider-jgit [2]. Since this isn't yet ready to be merged into master as a whole, I had to chop the commits later. This is the reason why the subject doesn't perfectly fit, apologise.\n\nLieGrue,\nstrub\n\n[1] http://github.com/sonatype/JGit/tree/72dd9d071ce140f267b8b4effd34d122627135e6/org.spearce.jgit/src/org/spearce/jgit/simple\n[2] http://github.com/struberg/maven-scm-providers-git\n\n--- Robin Rosenberg <robin.rosenberg.lists@dewire.com> schrieb am Mi, 17.6.2009:\n\n> Von: Robin Rosenberg <robin.rosenberg.lists@dewire.com>\n> Betreff: Re: [EGIT PATCH2/2] fixed-toString-for-CommitTimeRevFilter-wrote-JUnit-tests\n> An: \"Mark Struberg\" <struberg@yahoo.de>\n> CC: git@vger.kernel.org, \"Shawn O. Pearce\" <spearce@spearce.org>\n> Datum: Mittwoch, 17. Juni 2009, 0:19\n> måndag 15 juni 2009 23:36:35 skrev\n> Mark Struberg <struberg@yahoo.de>:\n> > \n> > From 72dd9d071ce140f267b8b4effd34d122627135e6 Mon Sep\n> 17 00:00:00 2001\n> > From: Mark Struberg <struberg@yahoo.de>\n> > Date: Mon, 15 Jun 2009 08:07:53 +0200\n> > Subject: [PATCH] fixed toString for\n> CommitTimeRevFilter + wrote JUnit tests for after, before\n> and between walks\n> \n> What is the connection between the toString and the rest of\n> the patch? Should be\n> separate patches.\n> \n> You should sign off the patches.\n> \n> Start the subject with a capital letter.\n> \n> Technically it seemed ok, but I shouldn't have pushed them,\n> as I did, by mistake when pusing\n> Shawn's latest patch. The formal errors should have been\n> fixed firsts.\n> \n> -- robin\n\n\n      \n"}]}