threads / patch / 19783

patch, 2 partsFix two typos in the "Toggle filter by tree" tooltip

Subject: [PATCH QGit 1/2] Fix two typos in the "Toggle filter by tree" tooltip

## tl;dr

3 messages between Jun 12, 2009 and Jun 12, 2009. Diffs are folded; open one to read it.

replies: 2people: 2as markdown or json

Markus Heidelberg· Jun 12, 2009, 12:07 UTC · lore

Signed-off-by: Markus Heidelberg <markus.heidelberg@web.de>
---
 src/mainview.ui |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

Show changes to src/mainview.ui +1 −1

diff --git a/src/mainview.ui b/src/mainview.ui
index 4ddf43d..b3a94a6 100644
--- a/src/mainview.ui
+++ b/src/mainview.ui
@@ -460,7 +460,7 @@
     <string>Filter by tree</string>
    </property>
    <property name="toolTip">
-    <string>Filter by tree selection, multple selection allowed</string>
+    <string>Filter by tree selection, multiple selections allowed</string>
    </property>
    <property name="shortcut">
     <string>F</string>

-- 
1.6.3.2.236.ge505d

Markus Heidelberg· Jun 12, 2009, 12:07 UTC · re: Markus Heidelberg · lore

[PATCH QGit 2/2] Remove non-working shortcut key 'f' for "Toggle filter by tree"

It was introduced in commit cdb58c0 (Adding useful shortcuts, 2008-06-07), but didn't even work there, because the key 'f' was already reserved for "Go to file page", which caused the following message on stdout:

    QAction::eventFilter: Ambiguous shortcut overload: F

Now the shortcut works for jumping to the file view again.

Signed-off-by: Markus Heidelberg <markus.heidelberg@web.de>
---
 src/mainview.ui |    3 ---
 1 files changed, 0 insertions(+), 3 deletions(-)

Show changes to src/mainview.ui +0 −3

diff --git a/src/mainview.ui b/src/mainview.ui
index b3a94a6..3a257be 100644
--- a/src/mainview.ui
+++ b/src/mainview.ui
@@ -462,9 +462,6 @@
    <property name="toolTip">
     <string>Filter by tree selection, multiple selections allowed</string>
    </property>
-   <property name="shortcut">
-    <string>F</string>
-   </property>
   </action>
   <action name="ActShowTree">
    <property name="checkable">

-- 
1.6.3.2.236.ge505d

Marco Costalba· Jun 12, 2009, 16:52 UTC · re: Markus Heidelberg · lore

Re: [PATCH QGit 1/2] Fix two typos in the "Toggle filter by tree" tooltip

On Fri, Jun 12, 2009 at 14:07, Markus Heidelberg<markus.heidelberg@web.de> wrote:

>
> Signed-off-by: Markus Heidelberg <markus.heidelberg@web.de>
> ---

Thanks, all patches applied and pushed.