{"thread":{"id":"19783","subject":"[PATCH QGit 1/2] Fix two typos in the \"Toggle filter by tree\" tooltip","startedAt":"2009-06-12T12:07:58Z","lastAt":"2009-06-12T16:52:33Z","messageCount":3,"participants":["Markus Heidelberg","Marco Costalba"],"isPatch":true,"patchVersion":1,"patchTotal":2},"messages":[{"id":"116144","messageId":"5eda420491e42dbb85b86b688dd604f067d7136d.1244808064.git.markus.heidelberg@web.de","threadId":"19783","inReplyTo":null,"subject":"[PATCH QGit 1/2] Fix two typos in the \"Toggle filter by tree\" tooltip","fromName":"Markus Heidelberg","fromEmail":"markus.heidelberg@web.de","sentAt":"2009-06-12T12:07:58Z","receivedAt":"2009-06-12T12:07:58Z","isPatch":true,"sender":{"key":"markus.heidelberg@web.de","avatar":"https://avatars.githubusercontent.com/u/6334512?v=4"},"body":"\nSigned-off-by: Markus Heidelberg <markus.heidelberg@web.de>\n---\n src/mainview.ui |    2 +-\n 1 files changed, 1 insertions(+), 1 deletions(-)\n\ndiff --git a/src/mainview.ui b/src/mainview.ui\nindex 4ddf43d..b3a94a6 100644\n--- a/src/mainview.ui\n+++ b/src/mainview.ui\n@@ -460,7 +460,7 @@\n     <string>Filter by tree</string>\n    </property>\n    <property name=\"toolTip\">\n-    <string>Filter by tree selection, multple selection allowed</string>\n+    <string>Filter by tree selection, multiple selections allowed</string>\n    </property>\n    <property name=\"shortcut\">\n     <string>F</string>\n-- \n1.6.3.2.236.ge505d\n"},{"id":"116150","messageId":"8348b0b8496634626c558c8aed04e9720beadc97.1244808064.git.markus.heidelberg@web.de","threadId":"19783","inReplyTo":"5eda420491e42dbb85b86b688dd604f067d7136d.1244808064.git.markus.heidelberg@web.de","subject":"[PATCH QGit 2/2] Remove non-working shortcut key 'f' for \"Toggle filter by tree\"","fromName":"Markus Heidelberg","fromEmail":"markus.heidelberg@web.de","sentAt":"2009-06-12T12:07:59Z","receivedAt":"2009-06-12T12:07:59Z","isPatch":true,"sender":{"key":"markus.heidelberg@web.de","avatar":"https://avatars.githubusercontent.com/u/6334512?v=4"},"body":"It was introduced in commit cdb58c0 (Adding useful shortcuts,\n2008-06-07), but didn't even work there, because the key 'f' was already\nreserved for \"Go to file page\", which caused the following message on\nstdout:\n\n    QAction::eventFilter: Ambiguous shortcut overload: F\n\nNow the shortcut works for jumping to the file view again.\n\nSigned-off-by: Markus Heidelberg <markus.heidelberg@web.de>\n---\n src/mainview.ui |    3 ---\n 1 files changed, 0 insertions(+), 3 deletions(-)\n\ndiff --git a/src/mainview.ui b/src/mainview.ui\nindex b3a94a6..3a257be 100644\n--- a/src/mainview.ui\n+++ b/src/mainview.ui\n@@ -462,9 +462,6 @@\n    <property name=\"toolTip\">\n     <string>Filter by tree selection, multiple selections allowed</string>\n    </property>\n-   <property name=\"shortcut\">\n-    <string>F</string>\n-   </property>\n   </action>\n   <action name=\"ActShowTree\">\n    <property name=\"checkable\">\n-- \n1.6.3.2.236.ge505d\n"},{"id":"116168","messageId":"e5bfff550906120952i730d024aj8177f9c8ae1b24e@mail.gmail.com","threadId":"19783","inReplyTo":"5eda420491e42dbb85b86b688dd604f067d7136d.1244808064.git.markus.heidelberg@web.de","subject":"Re: [PATCH QGit 1/2] Fix two typos in the \"Toggle filter by tree\" tooltip","fromName":"Marco Costalba","fromEmail":"mcostalba@gmail.com","sentAt":"2009-06-12T16:52:33Z","receivedAt":"2009-06-12T16:52:33Z","isPatch":true,"sender":{"key":"mcostalba@gmail.com","avatar":null},"body":"On Fri, Jun 12, 2009 at 14:07, Markus\nHeidelberg<markus.heidelberg@web.de> wrote:\n>\n> Signed-off-by: Markus Heidelberg <markus.heidelberg@web.de>\n> ---\n\nThanks, all patches applied and pushed.\n"}]}