threads / patch / 19715

patch, 4 partsDon't count the submenu entries for checking if it is empty

Subject: [PATCH QGit 1/4] Don't count the submenu entries for checking if it is empty

## tl;dr

One message between Jun 6, 2009 and Jun 6, 2009. Diffs are folded; open one to read it.

replies: 0people: 1as markdown or json

Markus Heidelberg· Jun 6, 2009, 11:57 UTC · lore
Checking with isEmpty() is more effective.
Signed-off-by: Markus Heidelberg <markus.heidelberg@web.de>
---
 src/mainimpl.cpp |    6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)
Show changes to src/mainimpl.cpp +3 −3
diff --git a/src/mainimpl.cpp b/src/mainimpl.cpp
index 8c7b19e..60414ab 100644
--- a/src/mainimpl.cpp
+++ b/src/mainimpl.cpp
@@ -1179,7 +1179,7 @@ void MainImpl::doContexPopup(SCRef sha) {
 			act = contextRmtMenu.addAction(*it);
 			act->setData("Ref");
 		}
-		if (contextRmtMenu.actions().count() > 0)
+		if (!contextRmtMenu.isEmpty())
 			contextMenu.addMenu(&contextRmtMenu);
 
 		if (!bn.empty())
@@ -1194,7 +1194,7 @@ void MainImpl::doContexPopup(SCRef sha) {
 			act->setData("Ref");
 		}
 		if (!tn.empty())
-			if (contextSubMenu.actions().count() > 0)
+			if (!contextSubMenu.isEmpty())
 				contextSubMenu.addSeparator();
 			else
 				contextMenu.addSeparator();
@@ -1207,7 +1207,7 @@ void MainImpl::doContexPopup(SCRef sha) {
 
 			act->setData("Ref");
 		}
-		if (contextSubMenu.actions().count() > 0)
+		if (!contextSubMenu.isEmpty())
 			contextMenu.addMenu(&contextSubMenu);
 	}
 	contextMenu.exec(QCursor::pos());
-- 
1.6.3.2.213.g30b07

← back to recent threads