{"thread":{"id":"19715","subject":"[PATCH QGit 1/4] Don't count the submenu entries for checking if it is empty","startedAt":"2009-06-06T11:57:48Z","lastAt":"2009-06-06T11:57:48Z","messageCount":1,"participants":["Markus Heidelberg"],"isPatch":true,"patchVersion":1,"patchTotal":4},"messages":[{"id":"115644","messageId":"1244289471-698-2-git-send-email-markus.heidelberg@web.de","threadId":"19715","inReplyTo":null,"subject":"[PATCH QGit 1/4] Don't count the submenu entries for checking if it is empty","fromName":"Markus Heidelberg","fromEmail":"markus.heidelberg@web.de","sentAt":"2009-06-06T11:57:48Z","receivedAt":"2009-06-06T11:57:48Z","isPatch":true,"sender":{"key":"markus.heidelberg@web.de","avatar":"https://avatars.githubusercontent.com/u/6334512?v=4"},"body":"Checking with isEmpty() is more effective.\n\nSigned-off-by: Markus Heidelberg <markus.heidelberg@web.de>\n---\n src/mainimpl.cpp |    6 +++---\n 1 files changed, 3 insertions(+), 3 deletions(-)\n\ndiff --git a/src/mainimpl.cpp b/src/mainimpl.cpp\nindex 8c7b19e..60414ab 100644\n--- a/src/mainimpl.cpp\n+++ b/src/mainimpl.cpp\n@@ -1179,7 +1179,7 @@ void MainImpl::doContexPopup(SCRef sha) {\n \t\t\tact = contextRmtMenu.addAction(*it);\n \t\t\tact->setData(\"Ref\");\n \t\t}\n-\t\tif (contextRmtMenu.actions().count() > 0)\n+\t\tif (!contextRmtMenu.isEmpty())\n \t\t\tcontextMenu.addMenu(&contextRmtMenu);\n \n \t\tif (!bn.empty())\n@@ -1194,7 +1194,7 @@ void MainImpl::doContexPopup(SCRef sha) {\n \t\t\tact->setData(\"Ref\");\n \t\t}\n \t\tif (!tn.empty())\n-\t\t\tif (contextSubMenu.actions().count() > 0)\n+\t\t\tif (!contextSubMenu.isEmpty())\n \t\t\t\tcontextSubMenu.addSeparator();\n \t\t\telse\n \t\t\t\tcontextMenu.addSeparator();\n@@ -1207,7 +1207,7 @@ void MainImpl::doContexPopup(SCRef sha) {\n \n \t\t\tact->setData(\"Ref\");\n \t\t}\n-\t\tif (contextSubMenu.actions().count() > 0)\n+\t\tif (!contextSubMenu.isEmpty())\n \t\t\tcontextMenu.addMenu(&contextSubMenu);\n \t}\n \tcontextMenu.exec(QCursor::pos());\n-- \n1.6.3.2.213.g30b07\n"}]}