threads / patch / 19660

patchRe: [TopGit PATCH] pre-commit: check .topdeps for valid branches

Subject: Re: [TopGit PATCH] pre-commit: check .topdeps for valid branches

## tl;dr

3 messages between Jun 2, 2009 and Jun 4, 2009. Diffs are folded; open one to read it.

replies: 2people: 2as markdown or json

Bert Wesarg· Jun 2, 2009, 21:09 UTC · lore

[TopGit PATCH] pre-commit: check .topdeps for valid branches

Signed-off-by: Bert Wesarg <bert.wesarg@googlemail.com>

---
 hooks/pre-commit.sh |    3 +++
 1 files changed, 3 insertions(+), 0 deletions(-)

Show changes to hooks/pre-commit.sh +3 −0

diff --git a/hooks/pre-commit.sh b/hooks/pre-commit.sh
index 8e05a4e..1eae2e8 100644
--- a/hooks/pre-commit.sh
+++ b/hooks/pre-commit.sh
@@ -52,6 +52,9 @@ BEGIN      { in_hunk = 0; }
 /^[^@ +-]/ { in_hunk = 0; }
 ' |
 	while read newly_added; do
+		ref_exists "$newly_added" ||
+			die "Invalid branch as dependent: $newly_added"
+
 		# deps can be non-tgish but we can't run recurse_deps() on them
 		ref_exists "refs/top-bases/$newly_added" ||
 			continue

-- 
tg: (0f8cd77..) bw/check-valid-deps (depends on: bw/check-for-dep-cycle)

Uwe Kleine-König· Jun 4, 2009, 09:34 UTC · re: Bert Wesarg · lore

Hi Bert,

Show 16 quoted lines

> diff --git a/hooks/pre-commit.sh b/hooks/pre-commit.sh
> index 8e05a4e..1eae2e8 100644
> --- a/hooks/pre-commit.sh
> +++ b/hooks/pre-commit.sh
> @@ -52,6 +52,9 @@ BEGIN      { in_hunk = 0; }
>  /^[^@ +-]/ { in_hunk = 0; }
>  ' |
>  	while read newly_added; do
> +		ref_exists "$newly_added" ||
> +			die "Invalid branch as dependent: $newly_added"
> +
>  		# deps can be non-tgish but we can't run recurse_deps() on them
>  		ref_exists "refs/top-bases/$newly_added" ||
>  			continue
> -- 
> tg: (0f8cd77..) bw/check-valid-deps (depends on: bw/check-for-dep-cycle)

this patch doesn't apply to my branch. I'd say you didn't send out bw/check-for-dep-cycle (or I oversaw it).

Best regards Uwe

-- 
Pengutronix e.K.                              | Uwe Kleine-König            |
Industrial Linux Solutions                    | http://www.pengutronix.de/  |

Bert Wesarg· Jun 4, 2009, 12:18 UTC · re: Uwe Kleine-König · lore

2009/6/4 Uwe Kleine-König <u.kleine-koenig@pengutronix.de>:

Show 20 quoted lines

> Hi Bert,
>
>> diff --git a/hooks/pre-commit.sh b/hooks/pre-commit.sh
>> index 8e05a4e..1eae2e8 100644
>> --- a/hooks/pre-commit.sh
>> +++ b/hooks/pre-commit.sh
>> @@ -52,6 +52,9 @@ BEGIN      { in_hunk = 0; }
>>  /^[^@ +-]/ { in_hunk = 0; }
>>  ' |
>>       while read newly_added; do
>> +             ref_exists "$newly_added" ||
>> +                     die "Invalid branch as dependent: $newly_added"
>> +
>>               # deps can be non-tgish but we can't run recurse_deps() on them
>>               ref_exists "refs/top-bases/$newly_added" ||
>>                       continue
>> --
>> tg: (0f8cd77..) bw/check-valid-deps (depends on: bw/check-for-dep-cycle)
> this patch doesn't apply to my branch.  I'd say you didn't send out
> bw/check-for-dep-cycle (or I oversaw it).

I have forwarded it to you, but you may also want to clone my topgit tree at:

http://kgb2.thruhere.net/git/?p=bertw/topgit.git;a=summary

Now that repo.or.cz is up again, I will put this repo on this server next week.

Regards, Bert

>
> Best regards
> Uwe