{"thread":{"id":"19660","subject":"Re: [TopGit PATCH] pre-commit: check .topdeps for valid branches","startedAt":"2009-06-02T21:09:22Z","lastAt":"2009-06-04T12:18:04Z","messageCount":3,"participants":["Uwe Kleine-König","Bert Wesarg"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"299107","messageId":"1243976962-10486-1-git-send-email-bert.wesarg@googlemail.com","threadId":"19660","inReplyTo":"1243592316-10820-1-git-send-email-bert.wesarg@googlemail.com","subject":"[TopGit PATCH] pre-commit: check .topdeps for valid branches","fromName":"Bert Wesarg","fromEmail":"bert.wesarg@googlemail.com","sentAt":"2009-06-02T21:09:22Z","receivedAt":"2009-06-02T21:09:22Z","isPatch":true,"sender":{"key":"bert.wesarg@googlemail.com","avatar":"https://avatars.githubusercontent.com/u/111934?v=4"},"body":"Signed-off-by: Bert Wesarg <bert.wesarg@googlemail.com>\n\n---\n hooks/pre-commit.sh |    3 +++\n 1 files changed, 3 insertions(+), 0 deletions(-)\n\ndiff --git a/hooks/pre-commit.sh b/hooks/pre-commit.sh\nindex 8e05a4e..1eae2e8 100644\n--- a/hooks/pre-commit.sh\n+++ b/hooks/pre-commit.sh\n@@ -52,6 +52,9 @@ BEGIN      { in_hunk = 0; }\n /^[^@ +-]/ { in_hunk = 0; }\n ' |\n \twhile read newly_added; do\n+\t\tref_exists \"$newly_added\" ||\n+\t\t\tdie \"Invalid branch as dependent: $newly_added\"\n+\n \t\t# deps can be non-tgish but we can't run recurse_deps() on them\n \t\tref_exists \"refs/top-bases/$newly_added\" ||\n \t\t\tcontinue\n-- \ntg: (0f8cd77..) bw/check-valid-deps (depends on: bw/check-for-dep-cycle)\n"},{"id":"115420","messageId":"20090604093456.GA14548@pengutronix.de","threadId":"19660","inReplyTo":"1243976962-10486-1-git-send-email-bert.wesarg@googlemail.com","subject":"Re: [TopGit PATCH] pre-commit: check .topdeps for valid branches","fromName":"Uwe Kleine-König","fromEmail":"u.kleine-koenig@pengutronix.de","sentAt":"2009-06-04T09:34:56Z","receivedAt":"2009-06-04T09:34:56Z","isPatch":true,"sender":{"key":"u.kleine-koenig@pengutronix.de","avatar":"https://gravatar.com/avatar/354b5e3ceb2806a2f1e1e382ac29ddbdad18288654da62b61eb13583a857eee7?d=mp&s=160"},"body":"Hi Bert,\n\n> diff --git a/hooks/pre-commit.sh b/hooks/pre-commit.sh\n> index 8e05a4e..1eae2e8 100644\n> --- a/hooks/pre-commit.sh\n> +++ b/hooks/pre-commit.sh\n> @@ -52,6 +52,9 @@ BEGIN      { in_hunk = 0; }\n>  /^[^@ +-]/ { in_hunk = 0; }\n>  ' |\n>  \twhile read newly_added; do\n> +\t\tref_exists \"$newly_added\" ||\n> +\t\t\tdie \"Invalid branch as dependent: $newly_added\"\n> +\n>  \t\t# deps can be non-tgish but we can't run recurse_deps() on them\n>  \t\tref_exists \"refs/top-bases/$newly_added\" ||\n>  \t\t\tcontinue\n> -- \n> tg: (0f8cd77..) bw/check-valid-deps (depends on: bw/check-for-dep-cycle)\nthis patch doesn't apply to my branch.  I'd say you didn't send out\nbw/check-for-dep-cycle (or I oversaw it).\n\nBest regards\nUwe\n\n-- \nPengutronix e.K.                              | Uwe Kleine-König            |\nIndustrial Linux Solutions                    | http://www.pengutronix.de/  |\n"},{"id":"115426","messageId":"36ca99e90906040518h4bb92638y4d63fb5507b500a6@mail.gmail.com","threadId":"19660","inReplyTo":"20090604093456.GA14548@pengutronix.de","subject":"Re: [TopGit PATCH] pre-commit: check .topdeps for valid branches","fromName":"Bert Wesarg","fromEmail":"bert.wesarg@googlemail.com","sentAt":"2009-06-04T12:18:04Z","receivedAt":"2009-06-04T12:18:04Z","isPatch":true,"sender":{"key":"bert.wesarg@googlemail.com","avatar":"https://avatars.githubusercontent.com/u/111934?v=4"},"body":"2009/6/4 Uwe Kleine-König <u.kleine-koenig@pengutronix.de>:\n> Hi Bert,\n>\n>> diff --git a/hooks/pre-commit.sh b/hooks/pre-commit.sh\n>> index 8e05a4e..1eae2e8 100644\n>> --- a/hooks/pre-commit.sh\n>> +++ b/hooks/pre-commit.sh\n>> @@ -52,6 +52,9 @@ BEGIN      { in_hunk = 0; }\n>>  /^[^@ +-]/ { in_hunk = 0; }\n>>  ' |\n>>       while read newly_added; do\n>> +             ref_exists \"$newly_added\" ||\n>> +                     die \"Invalid branch as dependent: $newly_added\"\n>> +\n>>               # deps can be non-tgish but we can't run recurse_deps() on them\n>>               ref_exists \"refs/top-bases/$newly_added\" ||\n>>                       continue\n>> --\n>> tg: (0f8cd77..) bw/check-valid-deps (depends on: bw/check-for-dep-cycle)\n> this patch doesn't apply to my branch.  I'd say you didn't send out\n> bw/check-for-dep-cycle (or I oversaw it).\nI have forwarded it to you, but you may also want to clone my topgit tree at:\n\nhttp://kgb2.thruhere.net/git/?p=bertw/topgit.git;a=summary\n\nNow that repo.or.cz is up again, I will put this repo on this server next week.\n\nRegards,\nBert\n\n>\n> Best regards\n> Uwe\n"}]}