[EGIT PATCH] Some logging of errors GUI's.

Robin Rosenberg· Apr 13, 2009, 23:26 UTC · lore

Though, hopefully rare, we might want to have errors logged.

Signed-off-by: Robin Rosenberg <robin.rosenberg@dewire.com>
---
 .../GitCompareFileRevisionEditorInput.java         |    2 ++
 .../egit/ui/internal/dialogs/CommitDialog.java     |    3 +++
 2 files changed, 5 insertions(+), 0 deletions(-)

Show changes to 2 files +5 −0

org.spearce.egit.ui/src/org/spearce/egit/ui/internal/GitCompareFileRevisionEditorInput.java, org.spearce.egit.ui/src/org/spearce/egit/ui/internal/dialogs/CommitDialog.java

diff --git a/org.spearce.egit.ui/src/org/spearce/egit/ui/internal/GitCompareFileRevisionEditorInput.java b/org.spearce.egit.ui/src/org/spearce/egit/ui/internal/GitCompareFileRevisionEditorInput.java
index 49d4a42..88c867d 100644
--- a/org.spearce.egit.ui/src/org/spearce/egit/ui/internal/GitCompareFileRevisionEditorInput.java
+++ b/org.spearce.egit.ui/src/org/spearce/egit/ui/internal/GitCompareFileRevisionEditorInput.java
@@ -35,6 +35,7 @@
 import org.eclipse.team.internal.ui.synchronize.LocalResourceTypedElement;
 import org.eclipse.team.ui.synchronize.SaveableCompareEditorInput;
 import org.eclipse.ui.IWorkbenchPage;
+import org.spearce.egit.core.Activator;
 
 /**
  * The input provider for the compare editor when working on resources
@@ -327,6 +328,7 @@ private String getContentIdentifier(ITypedElement element){
 						return TeamUIMessages.CompareFileRevisionEditorInput_1;
 					}
 				} catch (CoreException e) {
+					Activator.logError("Problem getting content identifier", e);
 				}
 			} else {
 				return fileRevisionElement.getContentIdentifier();
diff --git a/org.spearce.egit.ui/src/org/spearce/egit/ui/internal/dialogs/CommitDialog.java b/org.spearce.egit.ui/src/org/spearce/egit/ui/internal/dialogs/CommitDialog.java
index e6bd02d..ce7196f 100644
--- a/org.spearce.egit.ui/src/org/spearce/egit/ui/internal/dialogs/CommitDialog.java
+++ b/org.spearce.egit.ui/src/org/spearce/egit/ui/internal/dialogs/CommitDialog.java
@@ -59,6 +59,7 @@
 import org.eclipse.team.core.history.IFileRevision;
 import org.eclipse.team.internal.ui.history.FileRevisionTypedElement;
 import org.eclipse.ui.model.WorkbenchLabelProvider;
+import org.spearce.egit.core.Activator;
 import org.spearce.egit.core.GitProvider;
 import org.spearce.egit.core.internal.storage.GitFileHistoryProvider;
 import org.spearce.egit.core.project.RepositoryMapping;
@@ -434,6 +435,8 @@ private static String getFileStatus(IFile file) {
 			}
 
 		} catch (Exception e) {
+			Activator.logError("Problem in finding file status", e);
+			prefix = e.getMessage();
 		}
 
 		return prefix;

-- 
1.6.2.2.446.gfbdc0

patchSome logging of errors GUI's.