{"thread":{"id":"18859","subject":"[EGIT PATCH] Some logging of errors GUI's.","startedAt":"2009-04-13T23:26:01Z","lastAt":"2009-04-13T23:26:01Z","messageCount":1,"participants":["Robin Rosenberg"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"111251","messageId":"1239665161-24033-1-git-send-email-robin.rosenberg@dewire.com","threadId":"18859","inReplyTo":null,"subject":"[EGIT PATCH] Some logging of errors GUI's.","fromName":"Robin Rosenberg","fromEmail":"robin.rosenberg@dewire.com","sentAt":"2009-04-13T23:26:01Z","receivedAt":"2009-04-13T23:26:01Z","isPatch":true,"sender":{"key":"robin.rosenberg@dewire.com","avatar":"https://avatars.githubusercontent.com/u/46357?v=4"},"body":"Though, hopefully rare, we might want to have errors logged.\n\nSigned-off-by: Robin Rosenberg <robin.rosenberg@dewire.com>\n---\n .../GitCompareFileRevisionEditorInput.java         |    2 ++\n .../egit/ui/internal/dialogs/CommitDialog.java     |    3 +++\n 2 files changed, 5 insertions(+), 0 deletions(-)\n\ndiff --git a/org.spearce.egit.ui/src/org/spearce/egit/ui/internal/GitCompareFileRevisionEditorInput.java b/org.spearce.egit.ui/src/org/spearce/egit/ui/internal/GitCompareFileRevisionEditorInput.java\nindex 49d4a42..88c867d 100644\n--- a/org.spearce.egit.ui/src/org/spearce/egit/ui/internal/GitCompareFileRevisionEditorInput.java\n+++ b/org.spearce.egit.ui/src/org/spearce/egit/ui/internal/GitCompareFileRevisionEditorInput.java\n@@ -35,6 +35,7 @@\n import org.eclipse.team.internal.ui.synchronize.LocalResourceTypedElement;\n import org.eclipse.team.ui.synchronize.SaveableCompareEditorInput;\n import org.eclipse.ui.IWorkbenchPage;\n+import org.spearce.egit.core.Activator;\n \n /**\n  * The input provider for the compare editor when working on resources\n@@ -327,6 +328,7 @@ private String getContentIdentifier(ITypedElement element){\n \t\t\t\t\t\treturn TeamUIMessages.CompareFileRevisionEditorInput_1;\n \t\t\t\t\t}\n \t\t\t\t} catch (CoreException e) {\n+\t\t\t\t\tActivator.logError(\"Problem getting content identifier\", e);\n \t\t\t\t}\n \t\t\t} else {\n \t\t\t\treturn fileRevisionElement.getContentIdentifier();\ndiff --git a/org.spearce.egit.ui/src/org/spearce/egit/ui/internal/dialogs/CommitDialog.java b/org.spearce.egit.ui/src/org/spearce/egit/ui/internal/dialogs/CommitDialog.java\nindex e6bd02d..ce7196f 100644\n--- a/org.spearce.egit.ui/src/org/spearce/egit/ui/internal/dialogs/CommitDialog.java\n+++ b/org.spearce.egit.ui/src/org/spearce/egit/ui/internal/dialogs/CommitDialog.java\n@@ -59,6 +59,7 @@\n import org.eclipse.team.core.history.IFileRevision;\n import org.eclipse.team.internal.ui.history.FileRevisionTypedElement;\n import org.eclipse.ui.model.WorkbenchLabelProvider;\n+import org.spearce.egit.core.Activator;\n import org.spearce.egit.core.GitProvider;\n import org.spearce.egit.core.internal.storage.GitFileHistoryProvider;\n import org.spearce.egit.core.project.RepositoryMapping;\n@@ -434,6 +435,8 @@ private static String getFileStatus(IFile file) {\n \t\t\t}\n \n \t\t} catch (Exception e) {\n+\t\t\tActivator.logError(\"Problem in finding file status\", e);\n+\t\t\tprefix = e.getMessage();\n \t\t}\n \n \t\treturn prefix;\n-- \n1.6.2.2.446.gfbdc0\n"}]}