cg-diff still broken on some BSDs

Martin Langhoff· Sep 20, 2005, 04:15 UTC · lore

Petr,

We still have a bug in cg-diff when using the BSD xargs. I posted a fix, and Junio posted an alternative approach. The original patches are here http://marc.theaimsgroup.com/?l=git&m=112541165904627&w=2

For some strange reason, it is not showing up on my OSX box, but it is definitely reproduceable in a proper FreeBSD box.

I am happy to rebase my patch (or Junio's) against current cogito if needed, but I rather do only one of them ;)

cheers,

martin

Petr Baudis· Sep 20, 2005, 19:36 UTC · re: Martin Langhoff · lore

Re: [PATCH] cg-diff fixed to work with BSD xargs

Dear diary, on Tue, Aug 30, 2005 at 12:00:10PM CEST, I got a letter where Martin Langhoff <martin@catalyst.net.nz> told me that...

Show 5 quoted lines

> Calls to cg-diff without filename parameters were dependent on GNU xargs
> traits. BSD xargs is hardcoded to do --no-run-if-empty -- so if the filter
> is effectively empty we avoid calling xargs.
> 
> Signed-off-by: Martin Langhoff <martin@catalyst.net.nz>

Thanks, I've applied it and also fixed the second git-diff-tree usage.

Dear diary, on Tue, Sep 20, 2005 at 06:15:28AM CEST, I got a letter where Martin Langhoff <martin.langhoff@gmail.com> told me that...

> We still have a bug in cg-diff when using the BSD xargs. I posted a
> fix, and Junio posted an alternative approach. The original patches
> are here http://marc.theaimsgroup.com/?l=git&m=112541165904627&w=2

Looks like I've overlooked it in my fast Cogito patch scan. There are still parts of mailing list history in late August and early September that I didn't read.

-- 
				Petr "Pasky" Baudis
Stuff: http://pasky.or.cz/
VI has two modes: the one in which it beeps and the one in which
it doesn't.