# cg-diff still broken on some BSDs

2 messages from 2005-09-20 to 2005-09-20. Participants: Martin Langhoff, Petr Baudis.
Thread: https://gitlist.dev/t/1881

## Martin Langhoff, 2005-09-20 04:15

Subject: cg-diff still broken on some BSDs
Message-ID: <46a038f905091921154a70123f@mail.gmail.com>
URL: https://gitlist.dev/e/46a038f905091921154a70123f%40mail.gmail.com

```
Petr,

We still have a bug in cg-diff when using the BSD xargs. I posted a
fix, and Junio posted an alternative approach. The original patches
are here http://marc.theaimsgroup.com/?l=git&m=112541165904627&w=2

For some strange reason, it is not showing up on my OSX box, but it is
definitely reproduceable in a proper FreeBSD box.

I am happy to rebase my patch (or Junio's) against current cogito if
needed, but I rather do only one of them ;)

cheers,


martin

```

## Petr Baudis, 2005-09-20 19:36

Subject: Re: [PATCH] cg-diff fixed to work with BSD xargs
Message-ID: <20050920193606.GD28621@pasky.or.cz>
URL: https://gitlist.dev/e/20050920193606.GD28621%40pasky.or.cz
In-Reply-To: <46a038f905091921154a70123f@mail.gmail.com>

```
Dear diary, on Tue, Aug 30, 2005 at 12:00:10PM CEST, I got a letter
where Martin Langhoff <martin@catalyst.net.nz> told me that...
> Calls to cg-diff without filename parameters were dependent on GNU xargs
> traits. BSD xargs is hardcoded to do --no-run-if-empty -- so if the filter
> is effectively empty we avoid calling xargs.
> 
> Signed-off-by: Martin Langhoff <martin@catalyst.net.nz>

Thanks, I've applied it and also fixed the second git-diff-tree usage.

Dear diary, on Tue, Sep 20, 2005 at 06:15:28AM CEST, I got a letter
where Martin Langhoff <martin.langhoff@gmail.com> told me that...
> We still have a bug in cg-diff when using the BSD xargs. I posted a
> fix, and Junio posted an alternative approach. The original patches
> are here http://marc.theaimsgroup.com/?l=git&m=112541165904627&w=2

Looks like I've overlooked it in my fast Cogito patch scan. There are
still parts of mailing list history in late August and early September
that I didn't read.

-- 
				Petr "Pasky" Baudis
Stuff: http://pasky.or.cz/
VI has two modes: the one in which it beeps and the one in which
it doesn't.

```
