threads / patch / 1851

patchFix syntax error in stg status

Subject: [PATCH] Fix syntax error in stg status

## tl;dr

2 messages between Sep 18, 2005 and Sep 19, 2005. Diffs are folded; open one to read it.

replies: 1people: 2as markdown or json

Paolo 'Blaisorblade' Giarrusso· Sep 18, 2005, 18:15 UTC · lore
From: Paolo 'Blaisorblade' Giarrusso <blaisorblade@yahoo.it>

Uff, it's becoming annoying - why things break so often? However, more to the point: turn a string into a list to allow appending it to another list.

Signed-off-by: Paolo 'Blaisorblade' Giarrusso <blaisorblade@yahoo.it>
---
 stgit/git.py |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
Show changes to stgit/git.py +1 −1
diff --git a/stgit/git.py b/stgit/git.py
--- a/stgit/git.py
+++ b/stgit/git.py
@@ -182,7 +182,7 @@ def __tree_status(files = [], tree_id = 
         base_exclude.append('--exclude-per-directory=.gitignore')
 
         if os.path.exists(exclude_file):
-            extra_exclude = '--exclude-from=%s' % exclude_file
+            extra_exclude = ['--exclude-from=%s' % exclude_file]
         else:
             extra_exclude = []
         if noexclude:
Catalin Marinas· Sep 19, 2005, 08:28 UTC · re: Paolo 'Blaisorblade' Giarrusso · lore

Re: [PATCH] Fix syntax error in stg status

On 18/09/05, Paolo 'Blaisorblade' Giarrusso <blaisorblade@yahoo.it> wrote:
> Uff, it's becoming annoying - why things break so often?

Because of the lack of regression testing (and also the Python's dynamic typing). After I release 0.7 this week, I'll start writing some tests.

Thanks for the patch.
-- 
Catalin

← back to recent threads