# [PATCH] Fix syntax error in stg status 2 messages from 2005-09-18 to 2005-09-19. Participants: Paolo 'Blaisorblade' Giarrusso, Catalin Marinas. Thread: https://gitlist.dev/t/1851 ## Paolo 'Blaisorblade' Giarrusso, 2005-09-18 18:15 Subject: [PATCH] Fix syntax error in stg status Message-ID: <20050918181551.21145.53583.stgit@zion.home.lan> URL: https://gitlist.dev/e/20050918181551.21145.53583.stgit%40zion.home.lan ``` From: Paolo 'Blaisorblade' Giarrusso Uff, it's becoming annoying - why things break so often? However, more to the point: turn a string into a list to allow appending it to another list. Signed-off-by: Paolo 'Blaisorblade' Giarrusso --- stgit/git.py | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/stgit/git.py b/stgit/git.py --- a/stgit/git.py +++ b/stgit/git.py @@ -182,7 +182,7 @@ def __tree_status(files = [], tree_id = base_exclude.append('--exclude-per-directory=.gitignore') if os.path.exists(exclude_file): - extra_exclude = '--exclude-from=%s' % exclude_file + extra_exclude = ['--exclude-from=%s' % exclude_file] else: extra_exclude = [] if noexclude: ``` ## Catalin Marinas, 2005-09-19 08:28 Subject: Re: [PATCH] Fix syntax error in stg status Message-ID: URL: https://gitlist.dev/e/b0943d9e05091901287f453611%40mail.gmail.com In-Reply-To: <20050918181551.21145.53583.stgit@zion.home.lan> ``` On 18/09/05, Paolo 'Blaisorblade' Giarrusso wrote: > Uff, it's becoming annoying - why things break so often? Because of the lack of regression testing (and also the Python's dynamic typing). After I release 0.7 this week, I'll start writing some tests. Thanks for the patch. -- Catalin ```