threads / rfc / 18466

[RFC] git gui doesn't call post-checkout hook on checkout or clone

Subject: [RFC] git gui doesn't call post-checkout hook on checkout or clone

## tl;dr

3 messages between Mar 22, 2009 and Mar 23, 2009.

replies: 2people: 3as markdown or json

Jens Lehmann· Mar 22, 2009, 15:49 UTC · lore

When checking out or cloning via git gui, the post-checkout hook is not called. This is a bit unexpected ...

The reason is that git gui uses git read-tree with the -u option and not git checkout and git clone. I changed git read-tree to call the post-checkout hook when called with -u and it seems to solve the problem. I would make a patch for that if you want.

But is this the right way to do this? Seems like we could surprise some users of git read-tree with this change in behaviour.

(I hope i cc'ed the right people this time ;-)

Jens

Jeff King· Mar 22, 2009, 22:33 UTC · re: Jens Lehmann · lore

Re: [RFC] git gui doesn't call post-checkout hook on checkout or clone

On Sun, Mar 22, 2009 at 04:49:05PM +0100, Jens Lehmann wrote:

Show 12 quoted lines

> When checking out or cloning via git gui, the post-checkout
> hook is not called. This is a bit unexpected ...
> 
> The reason is that git gui uses git read-tree with the -u
> option and not git checkout and git clone. I changed git
> read-tree to call the post-checkout hook when called with
> -u and it seems to solve the problem. I would make a patch
> for that if you want.
> 
> But is this the right way to do this? Seems like we could
> surprise some users of git read-tree with this change in
> behaviour.

No, I think plumbing should not generally call hooks. The right solution would be to have git-gui call the post-checkout hook.

-Peff

Shawn O. Pearce· Mar 23, 2009, 00:18 UTC · re: Jeff King · lore

Re: [RFC] git gui doesn't call post-checkout hook on checkout or clone

Jeff King <peff@peff.net> wrote:

> On Sun, Mar 22, 2009 at 04:49:05PM +0100, Jens Lehmann wrote:
> 
> > When checking out or cloning via git gui, the post-checkout
> > hook is not called. This is a bit unexpected ...

...

Show 6 quoted lines

> > But is this the right way to do this? Seems like we could
> > surprise some users of git read-tree with this change in
> > behaviour.
> 
> No, I think plumbing should not generally call hooks. The right solution
> would be to have git-gui call the post-checkout hook.

+1. git-gui should be invoking the hook. It doesn't. Patches are welcome. I don't really have time these days for doing my own development on git-gui, but well coded patches are still accepted.

-- 
Shawn.