# [RFC] git gui doesn't call post-checkout hook on checkout or clone

3 messages from 2009-03-22 to 2009-03-23. Participants: Jens Lehmann, Jeff King, Shawn O. Pearce.
Thread: https://gitlist.dev/t/18466

## Jens Lehmann, 2009-03-22 15:49

Subject: [RFC] git gui doesn't call post-checkout hook on checkout or clone
Message-ID: <49C65DF1.8030608@web.de>
URL: https://gitlist.dev/e/49C65DF1.8030608%40web.de

```
When checking out or cloning via git gui, the post-checkout
hook is not called. This is a bit unexpected ...

The reason is that git gui uses git read-tree with the -u
option and not git checkout and git clone. I changed git
read-tree to call the post-checkout hook when called with
-u and it seems to solve the problem. I would make a patch
for that if you want.

But is this the right way to do this? Seems like we could
surprise some users of git read-tree with this change in
behaviour.

(I hope i cc'ed the right people this time ;-)

Jens

```

## Jeff King, 2009-03-22 22:33

Subject: Re: [RFC] git gui doesn't call post-checkout hook on checkout or clone
Message-ID: <20090322223309.GA22428@sigill.intra.peff.net>
URL: https://gitlist.dev/e/20090322223309.GA22428%40sigill.intra.peff.net
In-Reply-To: <49C65DF1.8030608@web.de>

```
On Sun, Mar 22, 2009 at 04:49:05PM +0100, Jens Lehmann wrote:

> When checking out or cloning via git gui, the post-checkout
> hook is not called. This is a bit unexpected ...
> 
> The reason is that git gui uses git read-tree with the -u
> option and not git checkout and git clone. I changed git
> read-tree to call the post-checkout hook when called with
> -u and it seems to solve the problem. I would make a patch
> for that if you want.
> 
> But is this the right way to do this? Seems like we could
> surprise some users of git read-tree with this change in
> behaviour.

No, I think plumbing should not generally call hooks. The right solution
would be to have git-gui call the post-checkout hook.

-Peff

```

## Shawn O. Pearce, 2009-03-23 00:18

Subject: Re: [RFC] git gui doesn't call post-checkout hook on checkout or clone
Message-ID: <20090323001827.GG23521@spearce.org>
URL: https://gitlist.dev/e/20090323001827.GG23521%40spearce.org
In-Reply-To: <20090322223309.GA22428@sigill.intra.peff.net>

```
Jeff King <peff@peff.net> wrote:
> On Sun, Mar 22, 2009 at 04:49:05PM +0100, Jens Lehmann wrote:
> 
> > When checking out or cloning via git gui, the post-checkout
> > hook is not called. This is a bit unexpected ...
...
> > But is this the right way to do this? Seems like we could
> > surprise some users of git read-tree with this change in
> > behaviour.
> 
> No, I think plumbing should not generally call hooks. The right solution
> would be to have git-gui call the post-checkout hook.

+1.  git-gui should be invoking the hook.  It doesn't.  Patches are
welcome.  I don't really have time these days for doing my own
development on git-gui, but well coded patches are still accepted.

-- 
Shawn.

```