threads / patch / 17208

patch, 5 partsbash: refactor 'git log --pretty=<format>' options

Subject: [PATCH 5/5] bash: refactor 'git log --pretty=<format>' options

## tl;dr

2 messages between Jan 16, 2009 and Jan 16, 2009. Diffs are folded; open one to read it.

replies: 1people: 2as markdown or json

SZEDER Gábor· Jan 16, 2009, 16:02 UTC · lore

Both 'git log' and 'show' have the same '--pretty=<format>' option with the same formats. So refactor these formats into a common variable.

While at it, also add 'format:' to the list.
Signed-off-by: SZEDER Gábor <szeder@ira.uka.de>
---
 contrib/completion/git-completion.bash |    8 ++++----
 1 files changed, 4 insertions(+), 4 deletions(-)
Show changes to contrib/completion/git-completion.bash +4 −4
diff --git a/contrib/completion/git-completion.bash b/contrib/completion/git-completion.bash
index 3a26d2b..b5b40c2 100755
--- a/contrib/completion/git-completion.bash
+++ b/contrib/completion/git-completion.bash
@@ -947,6 +947,8 @@ _git_ls_tree ()
 	__git_complete_file
 }
 
+__git_log_pretty_formats="oneline short medium full fuller email raw format:"
+
 _git_log ()
 {
 	__git_has_doubledash && return
@@ -954,8 +956,7 @@ _git_log ()
 	local cur="${COMP_WORDS[COMP_CWORD]}"
 	case "$cur" in
 	--pretty=*)
-		__gitcomp "
-			oneline short medium full fuller email raw
+		__gitcomp "$__git_log_pretty_formats
 			" "" "${cur##--pretty=}"
 		return
 		;;
@@ -1487,8 +1488,7 @@ _git_show ()
 	local cur="${COMP_WORDS[COMP_CWORD]}"
 	case "$cur" in
 	--pretty=*)
-		__gitcomp "
-			oneline short medium full fuller email raw
+		__gitcomp "$__git_log_pretty_formats
 			" "" "${cur##--pretty=}"
 		return
 		;;
-- 
1.6.1.198.geb475f
Shawn O. Pearce· Jan 16, 2009, 17:18 UTC · re: SZEDER Gábor · lore

Re: [PATCH 5/5] bash: refactor 'git log --pretty=<format>' options

SZEDER Gábor <szeder@ira.uka.de> wrote:
Show 7 quoted lines
> Both 'git log' and 'show' have the same '--pretty=<format>' option
> with the same formats.  So refactor these formats into a common
> variable.
> 
> While at it, also add 'format:' to the list.
> 
> Signed-off-by: SZEDER Gábor <szeder@ira.uka.de>
For all 3 patches in the series:
Acked-by: Shawn O. Pearce <spearce@spearce.org>
Thanks.
-- 
Shawn.

← back to recent threads