# [PATCH 5/5] bash: refactor 'git log --pretty=<format>' options

2 messages from 2009-01-16 to 2009-01-16. Participants: SZEDER Gábor, Shawn O. Pearce.
Thread: https://gitlist.dev/t/17208

## SZEDER Gábor, 2009-01-16 16:02

Subject: [PATCH 5/5] bash: refactor 'git log --pretty=<format>' options
Message-ID: <1232121735-10239-1-git-send-email-szeder@ira.uka.de>
URL: https://gitlist.dev/e/1232121735-10239-1-git-send-email-szeder%40ira.uka.de

```
Both 'git log' and 'show' have the same '--pretty=<format>' option
with the same formats.  So refactor these formats into a common
variable.

While at it, also add 'format:' to the list.

Signed-off-by: SZEDER Gábor <szeder@ira.uka.de>
---
 contrib/completion/git-completion.bash |    8 ++++----
 1 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/contrib/completion/git-completion.bash b/contrib/completion/git-completion.bash
index 3a26d2b..b5b40c2 100755
--- a/contrib/completion/git-completion.bash
+++ b/contrib/completion/git-completion.bash
@@ -947,6 +947,8 @@ _git_ls_tree ()
 	__git_complete_file
 }
 
+__git_log_pretty_formats="oneline short medium full fuller email raw format:"
+
 _git_log ()
 {
 	__git_has_doubledash && return
@@ -954,8 +956,7 @@ _git_log ()
 	local cur="${COMP_WORDS[COMP_CWORD]}"
 	case "$cur" in
 	--pretty=*)
-		__gitcomp "
-			oneline short medium full fuller email raw
+		__gitcomp "$__git_log_pretty_formats
 			" "" "${cur##--pretty=}"
 		return
 		;;
@@ -1487,8 +1488,7 @@ _git_show ()
 	local cur="${COMP_WORDS[COMP_CWORD]}"
 	case "$cur" in
 	--pretty=*)
-		__gitcomp "
-			oneline short medium full fuller email raw
+		__gitcomp "$__git_log_pretty_formats
 			" "" "${cur##--pretty=}"
 		return
 		;;
-- 
1.6.1.198.geb475f

```

## Shawn O. Pearce, 2009-01-16 17:18

Subject: Re: [PATCH 5/5] bash: refactor 'git log --pretty=<format>' options
Message-ID: <20090116171816.GO10179@spearce.org>
URL: https://gitlist.dev/e/20090116171816.GO10179%40spearce.org
In-Reply-To: <1232121735-10239-1-git-send-email-szeder@ira.uka.de>

```
SZEDER Gábor <szeder@ira.uka.de> wrote:
> Both 'git log' and 'show' have the same '--pretty=<format>' option
> with the same formats.  So refactor these formats into a common
> variable.
> 
> While at it, also add 'format:' to the list.
> 
> Signed-off-by: SZEDER Gábor <szeder@ira.uka.de>

For all 3 patches in the series:

Acked-by: Shawn O. Pearce <spearce@spearce.org>

Thanks.

-- 
Shawn.

```