threads / patch / 16767

patchgitk: Swap positions of 'next' and 'prev' buttons in the 'Find' section.

Subject: [PATCH] gitk: Swap positions of 'next' and 'prev' buttons in the 'Find' section.

## tl;dr

2 messages between Dec 17, 2008 and Dec 21, 2008. Diffs are folded; open one to read it.

replies: 1people: 2as markdown or json

Johannes Sixt· Dec 17, 2008, 11:50 UTC · lore

From: Johannes Sixt <j6t@kdbg.org>

The button order 'prev' left of 'next' feels more natural than the other way round, in particular, compared to the order of the forward and backward arrows that are in the line above.

Signed-off-by: Johannes Sixt <j6t@kdbg.org>
---
 gitk-git/gitk |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

Show changes to gitk-git/gitk +1 −1

diff --git a/gitk-git/gitk b/gitk-git/gitk
index b63109b..1c8d98e 100644
--- a/gitk-git/gitk
+++ b/gitk-git/gitk
@@ -2052,7 +2052,7 @@ proc makewindow {} {
     button .tf.lbar.fnext -text [mc "next"] -command {dofind 1 1}
     button .tf.lbar.fprev -text [mc "prev"] -command {dofind -1 1}
     label .tf.lbar.flab2 -text " [mc "commit"] "
-    pack .tf.lbar.flabel .tf.lbar.fnext .tf.lbar.fprev .tf.lbar.flab2 \
+    pack .tf.lbar.flabel .tf.lbar.fprev .tf.lbar.fnext .tf.lbar.flab2 \
 	-side left -fill y
     set gdttype [mc "containing:"]
     set gm [tk_optionMenu .tf.lbar.gdttype gdttype \

-- 
1.6.1.rc3.980.ga0bb

Paul Mackerras· Dec 21, 2008, 22:59 UTC · re: Johannes Sixt · lore

Re: [PATCH] gitk: Swap positions of 'next' and 'prev' buttons in the 'Find' section.

Johannes Sixt writes:

> The button order 'prev' left of 'next' feels more natural than the other
> way round, in particular, compared to the order of the forward and backward
> arrows that are in the line above.

The next/prev labels are a bit awkward in any case, since "next" finds an earlier commit - one further down the list, and "prev" finds a later commit - one further back in the list. A better solution might be to make images for arrows pointing up and down and use compound buttons so the buttons say Find ^ and Find v (if you image the ^/v as up and down arrows).

I also find myself often wanting a "Find first" button, i.e. search starting at the top of the list.

Paul.