{"thread":{"id":"16767","subject":"[PATCH] gitk: Swap positions of 'next' and 'prev' buttons in the 'Find' section.","startedAt":"2008-12-17T11:50:17Z","lastAt":"2008-12-21T22:59:54Z","messageCount":2,"participants":["Johannes Sixt","Paul Mackerras"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"98126","messageId":"4948E779.9080909@viscovery.net","threadId":"16767","inReplyTo":null,"subject":"[PATCH] gitk: Swap positions of 'next' and 'prev' buttons in the 'Find' section.","fromName":"Johannes Sixt","fromEmail":"j.sixt@viscovery.net","sentAt":"2008-12-17T11:50:17Z","receivedAt":"2008-12-17T11:50:17Z","isPatch":true,"sender":{"key":"j6t@kdbg.org","avatar":"https://avatars.githubusercontent.com/u/14810926?v=4"},"body":"From: Johannes Sixt <j6t@kdbg.org>\n\nThe button order 'prev' left of 'next' feels more natural than the other\nway round, in particular, compared to the order of the forward and backward\narrows that are in the line above.\n\nSigned-off-by: Johannes Sixt <j6t@kdbg.org>\n---\n gitk-git/gitk |    2 +-\n 1 files changed, 1 insertions(+), 1 deletions(-)\n\ndiff --git a/gitk-git/gitk b/gitk-git/gitk\nindex b63109b..1c8d98e 100644\n--- a/gitk-git/gitk\n+++ b/gitk-git/gitk\n@@ -2052,7 +2052,7 @@ proc makewindow {} {\n     button .tf.lbar.fnext -text [mc \"next\"] -command {dofind 1 1}\n     button .tf.lbar.fprev -text [mc \"prev\"] -command {dofind -1 1}\n     label .tf.lbar.flab2 -text \" [mc \"commit\"] \"\n-    pack .tf.lbar.flabel .tf.lbar.fnext .tf.lbar.fprev .tf.lbar.flab2 \\\n+    pack .tf.lbar.flabel .tf.lbar.fprev .tf.lbar.fnext .tf.lbar.flab2 \\\n \t-side left -fill y\n     set gdttype [mc \"containing:\"]\n     set gm [tk_optionMenu .tf.lbar.gdttype gdttype \\\n-- \n1.6.1.rc3.980.ga0bb\n"},{"id":"98521","messageId":"18766.51818.313516.421046@cargo.ozlabs.ibm.com","threadId":"16767","inReplyTo":"4948E779.9080909@viscovery.net","subject":"Re: [PATCH] gitk: Swap positions of 'next' and 'prev' buttons in the 'Find' section.","fromName":"Paul Mackerras","fromEmail":"paulus@samba.org","sentAt":"2008-12-21T22:59:54Z","receivedAt":"2008-12-21T22:59:54Z","isPatch":true,"sender":{"key":"paulus@samba.org","avatar":"https://avatars.githubusercontent.com/u/1606439?v=4"},"body":"Johannes Sixt writes:\n\n> The button order 'prev' left of 'next' feels more natural than the other\n> way round, in particular, compared to the order of the forward and backward\n> arrows that are in the line above.\n\nThe next/prev labels are a bit awkward in any case, since \"next\" finds\nan earlier commit - one further down the list, and \"prev\" finds a\nlater commit - one further back in the list.  A better solution might\nbe to make images for arrows pointing up and down and use compound\nbuttons so the buttons say Find ^ and Find v (if you image the ^/v as\nup and down arrows).\n\nI also find myself often wanting a \"Find first\" button, i.e. search\nstarting at the top of the list.\n\nPaul.\n"}]}