threads / patch / 16637

patchDefine linkgit macro in [macros] section

Subject: [PATCH] Define linkgit macro in [macros] section

## tl;dr

3 messages between Dec 8, 2008 and Dec 9, 2008. Diffs are folded; open one to read it.

replies: 2people: 2as markdown or json

Alexey Borzenkov· Dec 8, 2008, 18:29 UTC · lore

Starting with asciidoc 8.3.0 linkgit macro is no longer recognized by asciidoc and user guide suggests (http://www.methods.co.nz/asciidoc/userguide.html#_macro_definitions) that macros are supposed to be defined in [macros] section. I'm not sure whether undefined linkgit macro was working by pure chance or it is a regression in asciidoc 8.3.0, but this patch adds proper definition for the linkgit macro, allowing it to work on 8.3.0.

Signed-off-by: Alexey Borzenkov <snaury@gmail.com>
---
 Documentation/asciidoc.conf |    3 +++
 1 files changed, 3 insertions(+), 0 deletions(-)

Show changes to Documentation/asciidoc.conf +3 −0

diff --git a/Documentation/asciidoc.conf b/Documentation/asciidoc.conf
index 2da867d..1e735df 100644
--- a/Documentation/asciidoc.conf
+++ b/Documentation/asciidoc.conf
@@ -7,6 +7,9 @@
 # Show GIT link as: <command>(<section>); if section is defined, else just show
 # the command.

+[macros]
+(?su)[\\]?(?P<name>linkgit):(?P<target>\S*?)\[(?P<attrlist>.*?)\]=
+
 [attributes]
 asterisk=&#42;
 plus=&#43;

-- 
1.6.0.4

Alexey Borzenkov· Dec 8, 2008, 20:13 UTC · re: Alexey Borzenkov · lore

Re: [PATCH] Define linkgit macro in [macros] section

Alexey Borzenkov <snaury <at> gmail.com> writes:

> I'm not sure whether undefined linkgit macro was working by pure chance
> or it is a regression in asciidoc 8.3.0,

I now found that the change in question was made in http://hg.sharesource.org/asciidoc/rev/82bdfd1a3674 and "catchall" macro is now commented out by default, all the more reason for git to define linkgit macro properly.

Junio C Hamano· Dec 9, 2008, 01:26 UTC · re: Alexey Borzenkov · lore

Re: [PATCH] Define linkgit macro in [macros] section

Thanks, and it does not change the output with older version (at least 7.1.2, I'll try with the one they have at k.org later tonight) in any negative way.

Will apply.