{"thread":{"id":"16637","subject":"[PATCH] Define linkgit macro in [macros] section","startedAt":"2008-12-08T18:29:09Z","lastAt":"2008-12-09T01:26:24Z","messageCount":3,"participants":["Alexey Borzenkov","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"97373","messageId":"e2480c70812081029s36eac963t76092c09af990ad@mail.gmail.com","threadId":"16637","inReplyTo":null,"subject":"[PATCH] Define linkgit macro in [macros] section","fromName":"Alexey Borzenkov","fromEmail":"snaury@gmail.com","sentAt":"2008-12-08T18:29:09Z","receivedAt":"2008-12-08T18:29:09Z","isPatch":true,"sender":{"key":"snaury@gmail.com","avatar":"https://gravatar.com/avatar/dd9f652303405e256f31e18690cea19ffcf21b83b04f746957334f62e399d95d?d=mp&s=160"},"body":"Starting with asciidoc 8.3.0 linkgit macro is no longer recognized by\nasciidoc and user guide suggests\n(http://www.methods.co.nz/asciidoc/userguide.html#_macro_definitions)\nthat macros are supposed to be defined in [macros] section. I'm not\nsure whether undefined linkgit macro was working by pure chance or it\nis a regression in asciidoc 8.3.0, but this patch adds proper\ndefinition for the linkgit macro, allowing it to work on 8.3.0.\n\nSigned-off-by: Alexey Borzenkov <snaury@gmail.com>\n---\n Documentation/asciidoc.conf |    3 +++\n 1 files changed, 3 insertions(+), 0 deletions(-)\n\ndiff --git a/Documentation/asciidoc.conf b/Documentation/asciidoc.conf\nindex 2da867d..1e735df 100644\n--- a/Documentation/asciidoc.conf\n+++ b/Documentation/asciidoc.conf\n@@ -7,6 +7,9 @@\n # Show GIT link as: <command>(<section>); if section is defined, else just show\n # the command.\n\n+[macros]\n+(?su)[\\\\]?(?P<name>linkgit):(?P<target>\\S*?)\\[(?P<attrlist>.*?)\\]=\n+\n [attributes]\n asterisk=&#42;\n plus=&#43;\n-- \n1.6.0.4\n"},{"id":"97382","messageId":"loom.20081208T201048-954@post.gmane.org","threadId":"16637","inReplyTo":"e2480c70812081029s36eac963t76092c09af990ad@mail.gmail.com","subject":"Re: [PATCH] Define linkgit macro in [macros] section","fromName":"Alexey Borzenkov","fromEmail":"snaury@gmail.com","sentAt":"2008-12-08T20:13:06Z","receivedAt":"2008-12-08T20:13:06Z","isPatch":true,"sender":{"key":"snaury@gmail.com","avatar":"https://gravatar.com/avatar/dd9f652303405e256f31e18690cea19ffcf21b83b04f746957334f62e399d95d?d=mp&s=160"},"body":"Alexey Borzenkov <snaury <at> gmail.com> writes:\n\n> I'm not sure whether undefined linkgit macro was working by pure chance\n> or it is a regression in asciidoc 8.3.0,\n\nI now found that the change in question was made in\nhttp://hg.sharesource.org/asciidoc/rev/82bdfd1a3674 and \"catchall\" macro is now\ncommented out by default, all the more reason for git to define linkgit macro\nproperly.\n"},{"id":"97394","messageId":"7vvdtu5ebj.fsf@gitster.siamese.dyndns.org","threadId":"16637","inReplyTo":"loom.20081208T201048-954@post.gmane.org","subject":"Re: [PATCH] Define linkgit macro in [macros] section","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2008-12-09T01:26:24Z","receivedAt":"2008-12-09T01:26:24Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Thanks, and it does not change the output with older version (at least\n7.1.2, I'll try with the one they have at k.org later tonight) in any\nnegative way.\n\nWill apply.\n"}]}