threads / patch / 16407

patchPrint help message when command is not proper

Subject: [TopGit PATCH] Print help message when command is not proper

## tl;dr

2 messages between Nov 20, 2008 and Nov 20, 2008. Diffs are folded; open one to read it.

replies: 1people: 2as markdown or json

martin f. krafft· Nov 20, 2008, 12:08 UTC · lore

When invoked with an unknown subcommand, or when --help is sought for a command that does not exist, TopGit prints the help message.

Signed-off-by: martin f. krafft <madduck@debian.org>

---
 tg.sh |    3 +++
 1 files changed, 3 insertions(+), 0 deletions(-)

Show changes to tg.sh +3 −0

diff --git a/tg.sh b/tg.sh
index 4dcc15e..2464612 100644
--- a/tg.sh
+++ b/tg.sh
@@ -232,6 +232,8 @@ do_help()
 		fi
 	else
 		echo "`basename $0`: no help for $1" 1>&2
+		do_help
+		exit 1
 	fi
 }
 
@@ -279,6 +281,7 @@ help|--help|-h)
 *)
 	[ -r "@cmddir@"/tg-$cmd ] || {
 		echo "Unknown subcommand: $cmd" >&2
+		do_help
 		exit 1
 	}
 	. "@cmddir@"/tg-$cmd;;

-- 
tg: (f17218e..) fixes/more-help (depends on: upstream)

Petr Baudis· Nov 20, 2008, 13:18 UTC · re: martin f. krafft · lore

Re: [TopGit PATCH] Print help message when command is not proper

On Thu, Nov 20, 2008 at 01:08:48PM +0100, martin f. krafft wrote:

> When invoked with an unknown subcommand, or when --help is sought for
> a command that does not exist, TopGit prints the help message.
> 
> Signed-off-by: martin f. krafft <madduck@debian.org>

Acked-by: Petr Baudis <pasky@suse.cz>

Note that I think these changes are reasonable only as long as do_help is just a short two-line usage help; in the event we also implement a longer help, it certainly shouldn't be printed in these cases.