# [TopGit PATCH] Print help message when command is not proper 2 messages from 2008-11-20 to 2008-11-20. Participants: martin f. krafft, Petr Baudis. Thread: https://gitlist.dev/t/16407 ## martin f. krafft, 2008-11-20 12:08 Subject: [TopGit PATCH] Print help message when command is not proper Message-ID: <1227182928-24916-1-git-send-email-madduck@debian.org> URL: https://gitlist.dev/e/1227182928-24916-1-git-send-email-madduck%40debian.org ``` When invoked with an unknown subcommand, or when --help is sought for a command that does not exist, TopGit prints the help message. Signed-off-by: martin f. krafft --- tg.sh | 3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/tg.sh b/tg.sh index 4dcc15e..2464612 100644 --- a/tg.sh +++ b/tg.sh @@ -232,6 +232,8 @@ do_help() fi else echo "`basename $0`: no help for $1" 1>&2 + do_help + exit 1 fi } @@ -279,6 +281,7 @@ help|--help|-h) *) [ -r "@cmddir@"/tg-$cmd ] || { echo "Unknown subcommand: $cmd" >&2 + do_help exit 1 } . "@cmddir@"/tg-$cmd;; -- tg: (f17218e..) fixes/more-help (depends on: upstream) ``` ## Petr Baudis, 2008-11-20 13:18 Subject: Re: [TopGit PATCH] Print help message when command is not proper Message-ID: <20081120131807.GE10491@machine.or.cz> URL: https://gitlist.dev/e/20081120131807.GE10491%40machine.or.cz In-Reply-To: <1227182928-24916-1-git-send-email-madduck@debian.org> ``` On Thu, Nov 20, 2008 at 01:08:48PM +0100, martin f. krafft wrote: > When invoked with an unknown subcommand, or when --help is sought for > a command that does not exist, TopGit prints the help message. > > Signed-off-by: martin f. krafft Acked-by: Petr Baudis Note that I think these changes are reasonable only as long as do_help is just a short two-line usage help; in the event we also implement a longer help, it certainly shouldn't be printed in these cases. ```