threads / patch / 16316

patchgitk: Add a menu option to start Git Gui.

Subject: [PATCH (GITK)] gitk: Add a menu option to start Git Gui.

## tl;dr

3 messages between Nov 13, 2008 and Nov 18, 2008. Diffs are folded; open one to read it.

replies: 2people: 2as markdown or json

Alexander Gavrilov· Nov 13, 2008, 20:12 UTC · lore

Git Gui already has menu commands to start gitk, and this makes the relation symmetric. Since gitk and git-gui complement each other, I think that it is beneficial to integrate them where it makes sense.

Signed-off-by: Alexander Gavrilov <angavrilov@gmail.com>
---
 gitk |    3 +++
 1 files changed, 3 insertions(+), 0 deletions(-)

Show changes to gitk +3 −0

diff --git a/gitk b/gitk
index 46896a2..e4562d7 100755
--- a/gitk
+++ b/gitk
@@ -1906,6 +1906,9 @@ proc makewindow {} {
 	    {mc "Reload" command reloadcommits -accelerator Meta1-F5}
 	    {mc "Reread references" command rereadrefs}
 	    {mc "List references" command showrefs -accelerator F2}
+	    {xx "" separator}
+	    {mc "Start Git Gui" command {exec git gui &}}
+	    {xx "" separator}
 	    {mc "Quit" command doquit -accelerator Meta1-Q}
 	}}
 	{mc "Edit" cascade {

-- 
1.6.0.3.15.gb8d36

Paul Mackerras· Nov 18, 2008, 09:33 UTC · re: Alexander Gavrilov · lore

Re: [PATCH (GITK)] gitk: Add a menu option to start Git Gui.

Alexander Gavrilov writes:

> Git Gui already has menu commands to start gitk,
> and this makes the relation symmetric. Since gitk and
> git-gui complement each other, I think that it is
> beneficial to integrate them where it makes sense.

I think it makes more sense to have this as an item on the context menu for the fake commit(s) for local changes.

Paul.

Alexander Gavrilov· Nov 18, 2008, 14:12 UTC · re: Paul Mackerras · lore

Re: [PATCH (GITK)] gitk: Add a menu option to start Git Gui.

On Tue, Nov 18, 2008 at 12:33 PM, Paul Mackerras <paulus@samba.org> wrote:

Show 8 quoted lines

> Alexander Gavrilov writes:
>> Git Gui already has menu commands to start gitk,
>> and this makes the relation symmetric. Since gitk and
>> git-gui complement each other, I think that it is
>> beneficial to integrate them where it makes sense.
>
> I think it makes more sense to have this as an item on the context
> menu for the fake commit(s) for local changes.

Git Gui is useful for a lot more things than just committing changes, e.g. you can interact with remote repositories, or do a merge, or amend the last commit message. Also, not everyone has local change display enabled in gitk.

Alexander