{"thread":{"id":"16316","subject":"[PATCH (GITK)] gitk: Add a menu option to start Git Gui.","startedAt":"2008-11-13T20:12:42Z","lastAt":"2008-11-18T14:12:30Z","messageCount":3,"participants":["Alexander Gavrilov","Paul Mackerras"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"95720","messageId":"200811132312.42150.angavrilov@gmail.com","threadId":"16316","inReplyTo":null,"subject":"[PATCH (GITK)] gitk: Add a menu option to start Git Gui.","fromName":"Alexander Gavrilov","fromEmail":"angavrilov@gmail.com","sentAt":"2008-11-13T20:12:42Z","receivedAt":"2008-11-13T20:12:42Z","isPatch":true,"sender":{"key":"angavrilov@gmail.com","avatar":"https://avatars.githubusercontent.com/u/42666?v=4"},"body":"Git Gui already has menu commands to start gitk,\nand this makes the relation symmetric. Since gitk and\ngit-gui complement each other, I think that it is\nbeneficial to integrate them where it makes sense.\n\nSigned-off-by: Alexander Gavrilov <angavrilov@gmail.com>\n---\n gitk |    3 +++\n 1 files changed, 3 insertions(+), 0 deletions(-)\n\ndiff --git a/gitk b/gitk\nindex 46896a2..e4562d7 100755\n--- a/gitk\n+++ b/gitk\n@@ -1906,6 +1906,9 @@ proc makewindow {} {\n \t    {mc \"Reload\" command reloadcommits -accelerator Meta1-F5}\n \t    {mc \"Reread references\" command rereadrefs}\n \t    {mc \"List references\" command showrefs -accelerator F2}\n+\t    {xx \"\" separator}\n+\t    {mc \"Start Git Gui\" command {exec git gui &}}\n+\t    {xx \"\" separator}\n \t    {mc \"Quit\" command doquit -accelerator Meta1-Q}\n \t}}\n \t{mc \"Edit\" cascade {\n-- \n1.6.0.3.15.gb8d36\n"},{"id":"96078","messageId":"18722.35810.362792.501694@cargo.ozlabs.ibm.com","threadId":"16316","inReplyTo":"200811132312.42150.angavrilov@gmail.com","subject":"Re: [PATCH (GITK)] gitk: Add a menu option to start Git Gui.","fromName":"Paul Mackerras","fromEmail":"paulus@samba.org","sentAt":"2008-11-18T09:33:22Z","receivedAt":"2008-11-18T09:33:22Z","isPatch":true,"sender":{"key":"paulus@samba.org","avatar":"https://avatars.githubusercontent.com/u/1606439?v=4"},"body":"Alexander Gavrilov writes:\n\n> Git Gui already has menu commands to start gitk,\n> and this makes the relation symmetric. Since gitk and\n> git-gui complement each other, I think that it is\n> beneficial to integrate them where it makes sense.\n\nI think it makes more sense to have this as an item on the context\nmenu for the fake commit(s) for local changes.\n\nPaul.\n"},{"id":"96083","messageId":"bb6f213e0811180612k2183afcas2ba1dc379bfbb03b@mail.gmail.com","threadId":"16316","inReplyTo":"18722.35810.362792.501694@cargo.ozlabs.ibm.com","subject":"Re: [PATCH (GITK)] gitk: Add a menu option to start Git Gui.","fromName":"Alexander Gavrilov","fromEmail":"angavrilov@gmail.com","sentAt":"2008-11-18T14:12:30Z","receivedAt":"2008-11-18T14:12:30Z","isPatch":true,"sender":{"key":"angavrilov@gmail.com","avatar":"https://avatars.githubusercontent.com/u/42666?v=4"},"body":"On Tue, Nov 18, 2008 at 12:33 PM, Paul Mackerras <paulus@samba.org> wrote:\n> Alexander Gavrilov writes:\n>> Git Gui already has menu commands to start gitk,\n>> and this makes the relation symmetric. Since gitk and\n>> git-gui complement each other, I think that it is\n>> beneficial to integrate them where it makes sense.\n>\n> I think it makes more sense to have this as an item on the context\n> menu for the fake commit(s) for local changes.\n\nGit Gui is useful for a lot more things than just committing changes,\ne.g. you can interact with remote repositories, or do a merge, or\namend the last commit message. Also, not everyone has local change\ndisplay enabled in gitk.\n\nAlexander\n"}]}